Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cleanup wasm_hook.go #165

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Conversation

robert-zaremba
Copy link
Contributor

Updated few comments and simplified the code.

Updated few comments and simplified the code.
@github-actions github-actions bot added the ibc-hooks Label for items related to Osmosis' ibc-hooks implementation label Feb 27, 2024
@Reecepbcups
Copy link
Member

Reecepbcups commented May 22, 2024

The team just updated main to SDK v50, if you want to rebase on that I am happy to approve myself to get in the updated docs

If not I will update this PR when I can and get in

@Reecepbcups Reecepbcups changed the title chore: cleanup wasm_hook.go docs: cleanup wasm_hook.go May 22, 2024
Copy link
Member

@Reecepbcups Reecepbcups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as it is simplifying & in code documentation after significant wait.

@Reecepbcups Reecepbcups merged commit 68f9220 into cosmos:main Aug 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ibc-hooks Label for items related to Osmosis' ibc-hooks implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants