refactor: remove processed key and handling code #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtieri
added
BACKPORT
I cannot find a link to the code so this now links to the spec
jtieri
requested review from
agouin and
Reecepbcups
and removed request for
agouin
Reecepbcups
approved these changes
Sep 4, 2024
mergify bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* refactor: remove processed key and handling code * refactor: ensure the underlying apps `OnRecvPacket` callback is invoked * docs: fix broken link to Defund-Labs interquery. I cannot find a link to the code so this now links to the spec (cherry picked from commit 8cb681e)
mergify bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* refactor: remove processed key and handling code * refactor: ensure the underlying apps `OnRecvPacket` callback is invoked * docs: fix broken link to Defund-Labs interquery. I cannot find a link to the code so this now links to the spec (cherry picked from commit 8cb681e)
This was referenced Sep 4, 2024
jtieri
added a commit
that referenced
this pull request
Sep 4, 2024
* refactor: remove processed key and handling code * refactor: ensure the underlying apps `OnRecvPacket` callback is invoked * docs: fix broken link to Defund-Labs interquery. I cannot find a link to the code so this now links to the spec (cherry picked from commit 8cb681e) Co-authored-by: Justin Tieri <37750742+jtieri@users.noreply.github.com>
jtieri
added a commit
that referenced
this pull request
Sep 4, 2024
* refactor: remove processed key and handling code * refactor: ensure the underlying apps `OnRecvPacket` callback is invoked * docs: fix broken link to Defund-Labs interquery. I cannot find a link to the code so this now links to the spec (cherry picked from commit 8cb681e) Co-authored-by: Justin Tieri <37750742+jtieri@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
ProcessedKey, which was previously being used by the swap and forward middleware to determine if a packet being handled was already processed by a middleware further up in the stack. If a packet was previously processed by some other middleware then this value would be initialized via a value passed through a context, this would ensure the PFM would not make a second call into the underlying app and invoke theOnRecvPacketcallback twice, ensuring that the mint/burn voucher logic would not be invoked more than once.If for some reason there is a need to have this sort of handling in the future then we can revisit bringing in this code.