Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: alternate consensus engines #1490

Merged
merged 9 commits into from
Sep 16, 2024
Merged

refactor: alternate consensus engines #1490

merged 9 commits into from
Sep 16, 2024

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Sep 2, 2024

Summary

The relayer is tied heavily to CometBFT. To support Gordian w/ IBC, we need to generalize this. This adds a new interface that gives exactly what the relayer needs to satisfy CometBFT logic, without tying it directly to CometBFT client calls.

This way CometBFT can use the http RPC, while gordian can use its own http RPC or gRPC.

Future PRs

  • Update to SDK v0.52 / IBC-Go v10
  • add Gordian gRPC/RPC Support with simplified types
  • Add gordian <> cometbft IBC test

relayer/chains/cosmos/tx.go Outdated Show resolved Hide resolved
relayer/chains/cosmos/feegrant.go Outdated Show resolved Hide resolved
@Reecepbcups Reecepbcups changed the title feat: alternate consensus feat: alternate consensus engines Sep 2, 2024
@Reecepbcups Reecepbcups marked this pull request as ready for review September 2, 2024 23:46
@Reecepbcups Reecepbcups requested a review from a team as a code owner September 2, 2024 23:46
@Reecepbcups Reecepbcups changed the title feat: alternate consensus engines refactor: alternate consensus engines Sep 3, 2024
Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good! this is a great refactor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants