-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CBL-4719: ReplicatorAPITest::options() Set proxy settings from _sg.proxy #1843
Conversation
Code Coverage Results:
|
Where is this used? Do you put it up based on doc or current use in the code base? Adding a comment will be helpful. |
proxyType = slice(kC4ProxyTypeHTTP); | ||
case ProxyType::HTTPS: | ||
proxyType = slice(kC4ProxyTypeHTTPS); | ||
// TODO: Once SOCKS is implemented (CBL-4715) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not :D
It's not currently used, as it doesn't seem we have any tests for proxy. But if we do add any proxy tests, they should ™ just work, as this will set that up in |
CBL-4621: Include LogFileConfiguration details in file logs (#1845) CBL-4610: Missing some log files CBL-4719: ReplicatorAPITest::options() Set proxy settings from _sg.proxy (#1843) CBL-4412: Enhance checkpoint resolution algorithm when local and remote checkpoint are mismatched. (#1842) CBL-4331: Remove C4QueryOptions parameter from c4query_run⚠️ API changed for `c4query_run` -> `C4QueryOptions options` parameter has been removed. (CBL-4331)
CBL-4762: SQL++ column title for "*" to use collection name rather than collection path. (#1852) - Updated replicator protocol docs to discuss version vectors - Use C++ std::system_clock for RealClockSource CBL-4639: Use FTS match() in the WHERE clause of LEFT OUTER JOINS not… (#1846) - Updated version vector implementation This one includes the fix, CBL-4762, of an issue discovered in the previously staged commit that goes to Build 3.2.0-79: CBL-4621: Include LogFileConfiguration details in file logs (#1845) CBL-4610: Missing some log files CBL-4719: ReplicatorAPITest::options() Set proxy settings from _sg.proxy (#1843) CBL-4412: Enhance checkpoint resolution algorithm when local and remote checkpoint are mismatched. (#1842) CBL-4331: Remove C4QueryOptions parameter from c4query_run⚠️ API changed for `c4query_run` -> `C4QueryOptions options` parameter has been removed. (CBL-4331)
CBL-4762: SQL++ column title for "*" to use collection name rather than collection path. (#1852) - Updated replicator protocol docs to discuss version vectors - Use C++ std::system_clock for RealClockSource CBL-4639: Use FTS match() in the WHERE clause of LEFT OUTER JOINS not… (#1846) - Updated version vector implementation CBL-4621: Include LogFileConfiguration details in file logs (#1845) CBL-4610: Missing some log files CBL-4719: ReplicatorAPITest::options() Set proxy settings from _sg.proxy (#1843) CBL-4412: Enhance checkpoint resolution algorithm when local and remote checkpoint are mismatched. (#1842) CBL-4331: Remove C4QueryOptions parameter from c4query_run⚠️ API changed for `c4query_run` -> `C4QueryOptions options` parameter has been removed. (CBL-4331)
I think I've set the proxy options appropriately, but I don't believe we have any proxy tests? So it might be good to add some alongside this PR, if possible.