CBL-4719: ReplicatorAPITest::options() Set proxy settings from _sg.proxy #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage Results:
|
|
Where is this used? Do you put it up based on doc or current use in the code base? Adding a comment will be helpful. |
borrrden
approved these changes
Jul 20, 2023
| proxyType = slice(kC4ProxyTypeHTTP); | ||
| case ProxyType::HTTPS: | ||
| proxyType = slice(kC4ProxyTypeHTTPS); | ||
| // TODO: Once SOCKS is implemented (CBL-4715) |
It's not currently used, as it doesn't seem we have any tests for proxy. But if we do add any proxy tests, they should ™ just work, as this will set that up in |
pasin
approved these changes
Jul 20, 2023
jianminzhao
approved these changes
Jul 20, 2023
jianminzhao
added a commit
that referenced
this pull request
Jul 24, 2023
CBL-4621: Include LogFileConfiguration details in file logs (#1845) CBL-4610: Missing some log files CBL-4719: ReplicatorAPITest::options() Set proxy settings from _sg.proxy (#1843) CBL-4412: Enhance checkpoint resolution algorithm when local and remote checkpoint are mismatched. (#1842) CBL-4331: Remove C4QueryOptions parameter from c4query_run⚠️ API changed for `c4query_run` -> `C4QueryOptions options` parameter has been removed. (CBL-4331)
jianminzhao
added a commit
that referenced
this pull request
Jul 30, 2023
CBL-4762: SQL++ column title for "*" to use collection name rather than collection path. (#1852) - Updated replicator protocol docs to discuss version vectors - Use C++ std::system_clock for RealClockSource CBL-4639: Use FTS match() in the WHERE clause of LEFT OUTER JOINS not… (#1846) - Updated version vector implementation This one includes the fix, CBL-4762, of an issue discovered in the previously staged commit that goes to Build 3.2.0-79: CBL-4621: Include LogFileConfiguration details in file logs (#1845) CBL-4610: Missing some log files CBL-4719: ReplicatorAPITest::options() Set proxy settings from _sg.proxy (#1843) CBL-4412: Enhance checkpoint resolution algorithm when local and remote checkpoint are mismatched. (#1842) CBL-4331: Remove C4QueryOptions parameter from c4query_run⚠️ API changed for `c4query_run` -> `C4QueryOptions options` parameter has been removed. (CBL-4331)
jianminzhao
added a commit
that referenced
this pull request
Aug 8, 2023
CBL-4762: SQL++ column title for "*" to use collection name rather than collection path. (#1852) - Updated replicator protocol docs to discuss version vectors - Use C++ std::system_clock for RealClockSource CBL-4639: Use FTS match() in the WHERE clause of LEFT OUTER JOINS not… (#1846) - Updated version vector implementation CBL-4621: Include LogFileConfiguration details in file logs (#1845) CBL-4610: Missing some log files CBL-4719: ReplicatorAPITest::options() Set proxy settings from _sg.proxy (#1843) CBL-4412: Enhance checkpoint resolution algorithm when local and remote checkpoint are mismatched. (#1842) CBL-4331: Remove C4QueryOptions parameter from c4query_run⚠️ API changed for `c4query_run` -> `C4QueryOptions options` parameter has been removed. (CBL-4331)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I've set the proxy options appropriately, but I don't believe we have any proxy tests? So it might be good to add some alongside this PR, if possible.