Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target ubuntu-latest explicitely when running depency-review [DT-7006] #133

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

jonapich
Copy link
Member

feat: **Target ubuntu-latest directly when running dependency-review **

https://coveord.atlassian.net/browse/DT-7006

Summary of changes:

  • The dependency-review workflow now targets ubuntu-latest directly instead of using the default.

We are changing the default value of the dependency-review action to target our self-hosted runners.
Therefore, public repositories must be adjusted prior else they will not be able to run the workflow anymore.

You should adjust and merge this pull request yourself if you're OK with it.
Feel free to comment if there's an issue!

feat: **Target ubuntu-latest directly when running dependency-review **

https://coveord.atlassian.net/browse/DT-7006

Summary of changes:
  - The `dependency-review` workflow now targets `ubuntu-latest` directly instead of using the default.

We are changing the default value of the `dependency-review` action to target our self-hosted runners.
Therefore, public repositories must be adjusted prior else they will not be able to run the workflow anymore.

*You should adjust and merge this pull request yourself if you're OK with it.
Feel free to comment if there's an issue!*
@jonapich jonapich requested review from dblanchette, a team, erocheleau and mikegron July 16, 2024 09:41
@jonapich
Copy link
Member Author

@erocheleau @mikegron The jenkins run is failing, can you look into it?

@erocheleau erocheleau merged commit aeef377 into master Jul 29, 2024
4 of 5 checks passed
@erocheleau erocheleau deleted the feature/DT-7006-dependency-review-ubuntu-latest branch July 29, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants