Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support the registry option when publishing NPM packages #189

Merged
merged 3 commits into from
Oct 5, 2023
Merged

feat: add support the registry option when publishing NPM packages #189

merged 3 commits into from
Oct 5, 2023

Conversation

malaporte
Copy link
Member

This will allow publishing packages from ui-kit both to NPM and to GitHub packages in the @coveo org

@malaporte malaporte requested a review from a team October 5, 2023 13:57
@malaporte malaporte requested a review from a team as a code owner October 5, 2023 13:57
@malaporte malaporte requested review from gdostie, dmgauthier, olamothe, y-lakhdar, mrrajamanickam-coveo and louis-bompart and removed request for a team October 5, 2023 13:57
gdostie
gdostie approved these changes Oct 5, 2023
View reviewed changes
src/npm/doNpmPublish.ts Outdated Show resolved Hide resolved
@malaporte malaporte mentioned this pull request Oct 5, 2023
Merged
btaillon-coveo
btaillon-coveo approved these changes Oct 5, 2023
View reviewed changes
Copy link

@btaillon-coveo btaillon-coveo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's probably workarounds to avoid needing to publish to both sources (probably involving something like Verdaccio), but this is free and GitHub Packages is nice so 🤷

@louis-bompart louis-bompart merged commit ebc6a55 into main Oct 5, 2023
4 checks passed
@louis-bompart louis-bompart deleted the feat/npm-registry-option branch October 5, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btaillon-coveo btaillon-coveo btaillon-coveo approved these changes

@gdostie gdostie gdostie approved these changes

@y-lakhdar y-lakhdar y-lakhdar approved these changes

@olamothe olamothe olamothe approved these changes

@dmgauthier dmgauthier Awaiting requested review from dmgauthier

@mrrajamanickam-coveo mrrajamanickam-coveo Awaiting requested review from mrrajamanickam-coveo mrrajamanickam-coveo is a code owner automatically assigned from coveo/dx

@louis-bompart louis-bompart Awaiting requested review from louis-bompart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@malaporte @olamothe @y-lakhdar @gdostie @btaillon-coveo @louis-bompart