-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: promote the v2 branch when publishing on v2 #4584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
louis-bompart
temporarily deployed
to
PR Artifacts
October 22, 2024 21:27 — with
GitHub Actions
Inactive
louis-bompart
changed the title
npm prod v2 fix
chore: promote the v2 branch when publishing on v2
Oct 22, 2024
louis-bompart
force-pushed
the
npm-prod-v2-fix
branch
from
October 22, 2024 22:07
2e68e39
to
5b04376
Compare
louis-bompart
temporarily deployed
to
PR Artifacts
October 22, 2024 22:18 — with
GitHub Actions
Inactive
louis-bompart
requested review from
erocheleau,
SimonMilord,
mmitiche,
olamothe,
fpbrault,
y-lakhdar and
alexprudhomme
October 23, 2024 17:11
louis-bompart
force-pushed
the
npm-prod-v2-fix
branch
from
October 23, 2024 17:11
5b04376
to
adac355
Compare
fbeaudoincoveo
approved these changes
Oct 23, 2024
Please add Jira link in description when you merge |
louis-bompart
temporarily deployed
to
PR Artifacts
October 23, 2024 17:22 — with
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
October 23, 2024 18:21 — with
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
October 23, 2024 19:03 — with
GitHub Actions
Inactive
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sames as #4584 for v3 Technically, we could "just fix" the script. However, I think it's best to make it "fit" with the rest of our release scripts in its code architecture while keeping the same functionality https://coveord.atlassian.net/browse/KIT-3668
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-3668