Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: promote the v2 branch when publishing on v2 #4584

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Oct 22, 2024

Copy link

github-actions bot commented Oct 22, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.5 244.5 0
commerce 343.1 343.1 0
search 417.2 417.2 0
insight 395 395 0
product-listing 306.8 306.8 0
product-recommendation 215.3 215.3 0
recommendation 257.7 257.7 0
ssr 407.7 407.7 0
ssr-commerce 353.7 353.7 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@louis-bompart louis-bompart changed the title npm prod v2 fix chore: promote the v2 branch when publishing on v2 Oct 22, 2024
@louis-bompart louis-bompart marked this pull request as ready for review October 23, 2024 17:11
@louis-bompart louis-bompart requested review from a team as code owners October 23, 2024 17:11
@fbeaudoincoveo
Copy link
Contributor

Please add Jira link in description when you merge

@louis-bompart louis-bompart added this pull request to the merge queue Oct 23, 2024
@louis-bompart louis-bompart removed this pull request from the merge queue due to a manual request Oct 23, 2024
@louis-bompart louis-bompart merged commit 9b5ffa8 into v2 Oct 23, 2024
115 checks passed
@louis-bompart louis-bompart deleted the npm-prod-v2-fix branch October 23, 2024 19:03
github-merge-queue bot pushed a commit that referenced this pull request Oct 23, 2024
Sames as #4584 for v3

Technically, we could "just fix" the script.
However, I think it's best to make it "fit" with the rest of our release
scripts in its code architecture while keeping the same functionality

https://coveord.atlassian.net/browse/KIT-3668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants