feat(slippage): small order slippage v2

[alfetopito]

Update 2024/10/03

Added feature flag smartSlippageFeeMultiplierPercentage, that returns the multiplier value and can still be used to feature flag the individual feature of small orders slippage.

Also, slippage is now capped at 50%.

New testing steps

1. Enable smartSlippageFeeMultiplierPercentage and disable isSmartSlippageEnabled
2. Pick sell/buy/amounts and observe the suggested slippage

• Should still work independent from BFF's slippage

3. Pick a tiny sell amount and observe the UI and the console logs

• Max suggested UI value should be 50%
• Console logs should show more than 5000
  

One more fun test is to add/pick new values to be served when on for the new feature flag:

And then observe the slippage change accordingly in the UI.

Summary

Supersedes #4911

Instead of using the fee % in relation to order size, calculate how much slippage is needed if the fee is 50% higher.
This value is added to the one returned by BFF.

⚠️ Tooltips still not updated

To Test

1. Make sure the Launch darkly flag is on
2. This will depend on current network conditions, so play around with input amounts to get it within those ranges
3. Place the order

• Should trade somewhat fast, hopefully. Not guaranteed, though.

You can also observe all the smart slippage values by filtering the console logs by SmartSlippage

• Granular value proposed on feat(slippage): smart slippage for high fee orders #4911
• The 50% fee increased from this PR
• BFF suggested slippage amount
  

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
cosmos	✅ Ready (Inspect)	Visit Preview	Oct 3, 2024 6:00pm
cowfi	✅ Ready (Inspect)	Visit Preview	Oct 3, 2024 6:00pm
explorer-dev	✅ Ready (Inspect)	Visit Preview	Oct 3, 2024 6:00pm
swap-dev	✅ Ready (Inspect)	Visit Preview	Oct 3, 2024 6:00pm
widget-configurator	✅ Ready (Inspect)	Visit Preview	Oct 3, 2024 6:00pm

[shoom3301]

The hooks deserves its own file :)
I would also suggest to extract the whole logic into a pure function and cover it by unit-tests

[elena-zh]

Hey @alfetopito , I have some questions to clarify/suggestions:

1. Why is the bff slippage added to the newly calculated one?
   

2. Why the slippage amount to add is so huge? Is this calculated on top of the granular slippage of 20%? Buy order:
   
   Sell order:
   

3. When I keep 'Confirm' modal opened, I can see that slippage amount is constantly changing there. IMO, it is not good thing as it leads to the trade outcome change. So I'd whether show 'Price updated' warning on the modal OR freeze the slippage value on the modal until the order placement
   

4. When a price is loaded, I can see several slippage requests on console. Is this OK?
   

5. As we discussed in the meeting, we have 50% slippage limitation in the settings, so it would be nice to have it as a max when calculating a custom one