Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(widget-configurator): use different default partner fee address for gchain #4942

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alfetopito
Copy link
Collaborator

Summary

Fixes #4937

Note: pointing to main to release is as a hotfix. It should go live as soon as it's merged, not needing a deployment.

To Test

  1. Open widget configurator
  2. Set partner fee to a value > 0
  3. Place a SWAP order on every chain
  • Gchain should use the new address
  • All other chains should use the former address

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Oct 3, 2024 4:48pm
cowfi ✅ Ready (Inspect) Visit Preview Oct 3, 2024 4:48pm
explorer-dev ✅ Ready (Inspect) Visit Preview Oct 3, 2024 4:48pm
swap-dev ✅ Ready (Inspect) Visit Preview Oct 3, 2024 4:48pm
widget-configurator ✅ Ready (Inspect) Visit Preview Oct 3, 2024 4:48pm

Comment on lines -14 to +15
const prKey = window.location.hostname.replace('widget-configurator-git-', '').replace('-cowswap.vercel.app', '')
return `https://swap-dev-git-${prKey}-cowswap.vercel.app`
// TODO: revert before merging!!
return 'https://swap-dev-git-fix-widget-configurator-fee-recipient-cowswap.vercel.app/'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to revert this before merging!!

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RELEASE Included in the release that is being closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants