Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Dvrk #128

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

[WIP] Dvrk #128

wants to merge 28 commits into from

Conversation

ahundt
Copy link
Collaborator

@ahundt ahundt commented May 12, 2018

We should probably merge this before it gets too stale.

@bcjiang can you help with this?

@bcjiang
Copy link
Collaborator

bcjiang commented May 13, 2018

@ahundt Yeah no problem, I can work on it tomorrow.

@cpaxton
Copy link
Owner

cpaxton commented May 13, 2018 via email

@bcjiang
Copy link
Collaborator

bcjiang commented May 13, 2018

On the dVRK machine it's 16.04 + Kinetic. Is the master branch using Indigo?

@bcjiang
Copy link
Collaborator

bcjiang commented May 14, 2018

Hi, I tried to get the code running again but there are some errors. I talked to Anton and he told me that there might be a firmware change on dVRK. I can try the latest dVRK release which hopefully will come out this Wednesday. Just want to be sure everything works before merging.

I think I need to include some customized dVRK files to this branch and also a README to instruct the new users (and me, before I forget..) to deploy things on dVRK. I will try to finish this PR by next week.

@ahundt
Copy link
Collaborator Author

ahundt commented May 17, 2018

Cool thanks!

Be sure to check for dvrk vs not dvrk mode in shared code so it doesn't break the UR5/iiwa backends. particularly files like instructor_view.py code and costar_arm.py, plus any DVRK specific options should be optional.

In other particular CISST should not be required for the UR5 installation since it is such a huge messy pile of libraries.

Does that sound ok?

@ahundt
Copy link
Collaborator Author

ahundt commented May 17, 2018

Master branch should (hopefully) be able to run on both indigo + kinetic bc I got kinetic working a while ago on my workstation. Although the kinetic install sh script isn't there so who knows.

@bcjiang
Copy link
Collaborator

bcjiang commented May 23, 2018

Hey I just got the system working on the lastest dvrk release, now I'm trying to merge with master branch and resolve the conflicts. I don't think there is much modification on instructor_view or costar_arm -- most of the changes are for debugging purpose, the dvrk part should work with some stand alone files. A few changes may require some work but I will start resolving them tomorrow (and see if any later changes in costar would cause any problem). CISST is not required for compiling the dvrk code in costar, so I think it would not be a problem.

@ahundt
Copy link
Collaborator Author

ahundt commented May 23, 2018

Cool thanks! (to the others watching this thread we also discussed this a bit in person)

@ahundt ahundt changed the title Dvrk [WIP] Dvrk Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants