Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Build decoder graph" box in performance test is confusing #306

Open
mirh opened this issue Apr 14, 2017 · 4 comments
Open

"Build decoder graph" box in performance test is confusing #306

mirh opened this issue Apr 14, 2017 · 4 comments

Comments

@mirh
Copy link

mirh commented Apr 14, 2017

I mean, I think I lost 5 minutes trying to understand why changing source didn't affect the video benchmarked with "start".

I mean.. I guess it wouldn't hurt if it was already pre-filled with whatever you had opened before (should it exist)?
And perhaps "build graph" button should be grayed out when "settings are still the same"?

@mikecopperwhite
Copy link
Collaborator

To be honest, I've never used the graph building part of this dialog. I simply changed the dialog so that it could run performance tests on the existing graph rather than build and test in one step as I wanted detailed control of the graph building.

So yes, I'm sure graph building part of the dialog could be greatly improved. Auto populating the dialog from an arbitrary selection of filters wouldn't be trivial though.

@mirh
Copy link
Author

mirh commented Apr 19, 2017

Arbitrary selection?
Isn't what you had opened yourself "fixed"?

@mikecopperwhite
Copy link
Collaborator

No question the 'Build Decoder Graph' section of this dialog could be made more intuitive or even moved into its own dialog. It's not a particularly useful part of the application and is mostly obsolete due to improved graph editing and loading facilities in GSN. 'Build' should be called 'rebuild' really as clears the existing graph and rebuilds it. I'll tweak the wording here to make this dialog a bit clearer.

Personally I find it easier just to open a media file and render it from the main menu, optionally creating demuxer, decoder, time measurer or renderer filters first so that they are automatically used for rendering the media file if compatible. Once this is done simply save it as a GRF or GRFX file so that it can be loaded directly without having to revisit the build graph controls.

mikecopperwhite added a commit that referenced this issue Apr 20, 2017
…rformance test dialog. Previous revision was also for this change - log message re issue #298 is wrong.
@mirh
Copy link
Author

mirh commented Apr 20, 2017

Mhh, I don't think the "build decoder graph" is totally useless. Also, it should be build because technically if you hadn't open anything previously, that's what you are doing.

Personally I find it easier just to open a media file and render it from the main menu, optionally creating demuxer, decoder, time measurer or renderer filters first so that they are automatically used for rendering the media file if compatible.

Sure, though I can see a use case where I'm trying to compare different codecs speed, and where a drop-down menu readily available would help.


Long story short though, I'm not sure I have understood why "reading which file/codec had already been opened/loaded" would be so problematic.
EDIT: seriously, instead of the new note, this last thing I mentioned would be 10 times more clearly straightforward 👅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants