Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] exit MATLAB / Octave on failure when using the python CLI #1277

Merged
merged 7 commits into from
Jul 10, 2024

Conversation

Remi-Gau
Copy link
Contributor

Copy link
Contributor

sourcery-ai bot commented Jul 10, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 93 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (f53979a) to head (df5ae05).
Report is 105 commits behind head on main.

Files Patch % Lines
src/bidspm/cli.py 0.00% 61 Missing ⚠️
src/bidspm/parsers.py 0.00% 23 Missing ⚠️
src/bidspm/bidspm.py 0.00% 9 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f53979a) and HEAD (df5ae05). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (f53979a) HEAD (df5ae05)
ubuntu-latest_matlab-R2023a_fast 1 0
octave 2 0
ubuntu-latest_matlab-R2023a_slow 1 0
macos-latest_matlab-R2023a_fast 1 0
macos-latest_matlab-R2023a_slow 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #1277       +/-   ##
==========================================
- Coverage   79.57%   0.00%   -79.58%     
==========================================
  Files         285       5      -280     
  Lines        7742     301     -7441     
  Branches       40      49        +9     
==========================================
- Hits         6161       0     -6161     
+ Misses       1565     301     -1264     
+ Partials       16       0       -16     
Flag Coverage Δ
cli 0.00% <0.00%> (-39.00%) ⬇️
macos-latest_matlab-R2023a_fast ?
macos-latest_matlab-R2023a_slow ?
octave ?
ubuntu-latest_matlab-R2023a_fast ?
ubuntu-latest_matlab-R2023a_slow ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau merged commit 4659cd6 into cpp-lln-lab:main Jul 10, 2024
37 of 42 checks passed
@Remi-Gau Remi-Gau deleted the enh/exit_code branch July 10, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

errors when using python CLI should exit Octave or MATLAB
1 participant