WTrackMenu: Filtering: Promote m_pAddToNewCrateAct to member variable

cr7pt0gr4ph7 · Oct 16, 2024 · dfe7bc9 · dfe7bc9
1 parent cc07b49
commit dfe7bc9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/widget/wtrackmenu.cpp b/src/widget/wtrackmenu.cpp
@@ -377,6 +377,14 @@ void WTrackMenu::createActions() {
         connect(m_pSelectInLibraryAct, &QAction::triggered, this, &WTrackMenu::slotSelectInLibrary);
     }
 
+    if (featureIsEnabled(Feature::Crate)) {
+        m_pAddToNewCrateAct = new QAction(tr("Add to New Crate"), this);
+        connect(m_pAddToNewCrateAct,
+                &QAction::triggered,
+                this,
+                &WTrackMenu::addSelectionToNewCrate);
+    }
+
     if (featureIsEnabled(Feature::Metadata)) {
         m_pImportMetadataFromFileAct =
                 new QAction(tr("Import From File Tags"), m_pMetadataMenu);
@@ -1543,9 +1551,7 @@ void WTrackMenu::slotPopulateCrateMenu() {
         connect(pCheckBox.get(), &QCheckBox::stateChanged, this, [this, pCheckBox{pCheckBox.get()}] { updateSelectionCrates(pCheckBox); });
     }
     m_pCrateMenu->addSeparator();
-    QAction* newCrateAction = new QAction(tr("Add to New Crate"), m_pCrateMenu);
-    m_pCrateMenu->addAction(newCrateAction);
-    connect(newCrateAction, &QAction::triggered, this, &WTrackMenu::addSelectionToNewCrate);
+    m_pCrateMenu->addAction(m_pAddToNewCrateAct);
     m_bCrateMenuLoaded = true;
 }
 

diff --git a/src/widget/wtrackmenu.h b/src/widget/wtrackmenu.h
@@ -269,6 +269,9 @@ class WTrackMenu : public QMenu {
     QMenu* m_pRemoveFromDiskMenu{};
 #endif
 
+    // Crate Submenu Actions
+    QAction* m_pAddToNewCrateAct{};
+
     // Update ReplayGain from Track
     QAction* m_pUpdateReplayGainAct{};