Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

img without src attribute set fails to load print preview #418

Open
clivevan opened this issue Mar 2, 2020 · 1 comment
Open

img without src attribute set fails to load print preview #418

clivevan opened this issue Mar 2, 2020 · 1 comment

Comments

@clivevan
Copy link

clivevan commented Mar 2, 2020

When trying to load the print preview page for an 'html' print nothing happens when i have an image element that has no src attribute value.
The 'loadIframeImage' pollImage function loops forever trying to load it, and so the preview never shows.
I got it working by checking if image.src is not empty here:

function loadIframeImages(images) { ....

  if (image.src !== '') {
    promises.push(loadIframeImage(image));
  }

....

it's a hack for now, not sure if this is a permanent fix. had me scratching my head for a while as there were no console errors thrown for this.
Anyway; just logging in case it's something that can be fixed in the next version, or at least for anyone searching for a similar reason to their dilemma like i was.

@papscript
Copy link

#357 This one fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants