Make all relation fields selectable as thumbnail providers

#15651
craftcms · Sep 4, 2024 · 7fced54 · 7fced54
1 parent 5e23c85
commit 7fced54
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 16 deletions.
diff --git a/CHANGELOG-WIP.md b/CHANGELOG-WIP.md
@@ -1 +1,4 @@
 # Release Notes for Craft CMS 5.5 (WIP)
+
+### Administration
+- All relation fields can now be selected as field layouts’ thumbnail providers. ([#15651](https://github.com/craftcms/cms/discussions/15651))
diff --git a/src/fields/Assets.php b/src/fields/Assets.php
@@ -9,7 +9,6 @@
 
 use Craft;
 use craft\base\ElementInterface;
-use craft\base\ThumbableFieldInterface;
 use craft\elements\Asset;
 use craft\elements\conditions\ElementCondition;
 use craft\elements\db\AssetQuery;
@@ -47,7 +46,7 @@
  * @author Pixel & Tonic, Inc. <support@pixelandtonic.com>
  * @since 3.0.0
  */
-class Assets extends BaseRelationField implements ThumbableFieldInterface
+class Assets extends BaseRelationField
 {
     /**
      * @since 3.5.11
@@ -487,20 +486,6 @@ protected function previewHtml(ElementCollection $elements): string
         );
     }
 
-    /**
-     * @inheritdoc
-     */
-    public function getThumbHtml(mixed $value, ElementInterface $element, int $size): ?string
-    {
-        /** @var AssetQuery|ElementCollection $value */
-        if ($value instanceof AssetQuery) {
-            $handle = sprintf('%s-%s-%s', preg_replace('/:+/', '-', __METHOD__), $this->id, $size);
-            $value = (clone $value)->eagerly($handle);
-        }
-
-        return $value->one()?->getThumbHtml($size);
-    }
-
     // Events
     // -------------------------------------------------------------------------
 

diff --git a/src/fields/BaseRelationField.php b/src/fields/BaseRelationField.php
@@ -17,6 +17,7 @@
 use craft\base\MergeableFieldInterface;
 use craft\base\NestedElementInterface;
 use craft\base\RelationalFieldInterface;
+use craft\base\ThumbableFieldInterface;
 use craft\behaviors\EventBehavior;
 use craft\db\FixedOrderExpression;
 use craft\db\Query;
@@ -61,6 +62,7 @@ abstract class BaseRelationField extends Field implements
     InlineEditableFieldInterface,
     EagerLoadingFieldInterface,
     RelationalFieldInterface,
+    ThumbableFieldInterface,
     MergeableFieldInterface
 {
     /**
@@ -949,6 +951,20 @@ protected function previewHtml(ElementCollection $elements): string
         return Cp::elementPreviewHtml($elements->all());
     }
 
+    /**
+     * @inheritdoc
+     */
+    public function getThumbHtml(mixed $value, ElementInterface $element, int $size): ?string
+    {
+        /** @var ElementQueryInterface|ElementCollection $value */
+        if ($value instanceof ElementQueryInterface) {
+            $handle = sprintf('%s-%s-%s', preg_replace('/:+/', '-', __METHOD__), $this->id, $size);
+            $value = (clone $value)->eagerly($handle);
+        }
+
+        return $value->one()?->getThumbHtml($size);
+    }
+
     /**
      * @inheritdoc
      */