Feature/cms 1177 map element errors to field containers with data error key #14212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…containers-with-data-error-key
…containers-with-data-error-key # Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
…containers-with-data-error-key # Conflicts: # src/fields/Matrix.php
[ci skip]
brandonkelly
deleted the
feature/cms-1177-map-element-errors-to-field-containers-with-data-error-key
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fields now have a
data-error-keyattribute, which allows us to identify the key their validation errors have. This way, JS can accurately find and display errors for the correct fields. It simplifies deep linking from the error summary and improves the visibility of errors in the slideouts (e.g. for the matrix field).The key is added primarily via
fieldlayoutelements/BaseField.Additionally,
models/FieldLayoutFormgets a new$errorKeyPrefixproperty, which is used to prefix the attribute value (e.g. for nested fields, like matrix).Related issues
cms-1177
#12290