get trashed elements too, so that delete permanently works as expected #15645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonkelly
deleted the
bugfix/delete-permanently-and-nested-elements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when you soft delete an owner element, its nested elements get (correctly) marked as soft deleted, too. If you then go to view the trashed elements and decide to permanently delete that soft-deleted element, its nested ones won’t get hard deleted.
This PR ensures that the nested element manager‘s
deleteNestedElements()method also gets the trashed nested elements. This way, if the owner is hard deleted, the nested elements are too.Also, you can now hard-delete nested elements via the “Delete permanently” action from the nested element index (previously, it was still attempting to delete the ownership). Hard deletion of nested elements this was is irreversible.
Related issues
n/a