[4.x] Ability to limit the countries available for selection when editing an address #15711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-just
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Looks good to me!
I would maybe just consider adding a bit more info to the comment for the new Addresses::EVENT_DEFINE_ADDRESS_COUNTRIES event around adding new countries/changing country codes. Just a short summary of what we talked about - if you want to add new countries, you will have to use DI and create your own country repository?
…esses # Conflicts: # CHANGELOG-WIP.md
i-just
approved these changes
Sep 24, 2024
brandonkelly
deleted the
feature/add-get-country-list-method-for-addresses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some projects require the need to limit the list of countries available for selection.
This PR adds and event that, when triggered, can manipulate the countries return. This gives developers control over which are available to content authors.
In the changes I have updated instances where the code where we were calling the addressing libraries core method and replaced it with our own so we have the chance to trigger an event.
The instances replaced are those that end up with the list being shown to a content author.
The instances of a call to the library's
getList()method that has not been changed relate to validation of the address element. This call is still there to validate against the entire list of possible countries.Related issues
craftcms/commerce#3306