prevent creation of unnecessary provisional draft after full save #15945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
brandonkelly
deleted the
bugfix/15938-slideout-savebtn-unnecessary-provisional-draft
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue:
When you edit a canonical element in a slideout, make a change and quickly hit the “Save” button before the autosave kicks in, the element is saved, but afterwards, a provisional draft is still created with the updated content.
The issue was not occurring when using the save shortcut, as that path first ensures that the draft is saved before posting to
ElementsController->actionSave().Solution:
After fully saving the element in a slideout, trigger
checkFormto get the latest form values, but without creating a draft.Related issues
#15938