Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x]: After updating from Commerce 4 existing discount errors #3844

Open
imagehat opened this issue Jan 8, 2025 · 1 comment
Open

[5.x]: After updating from Commerce 4 existing discount errors #3844

imagehat opened this issue Jan 8, 2025 · 1 comment

Comments

@imagehat
Copy link

imagehat commented Jan 8, 2025

What happened?

Description

Existing discounts with conditions set result in an error of "Store ID is required", even when clicking into the discount in the control panel.

Steps to reproduce

  1. Have a discount with conditions set up in Commerce 4
  2. Update to Craft 5 / Commerce 5
  3. Go to Store Settings > Discounts
  4. Click into the migrated discount with conditions

Expected behavior

Discounts should be migrated during the upgrade to include the Store ID in the orderCondition column json value in the craft_commerce_discounts table.

Actual behavior

Store ID is not added to condition, resulting the error.

Craft CMS version

5.57

Craft Commerce version

5.2.9.1

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

Image
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant