Remove superflous attribute from event model

craftcms · Nov 2, 2023 · 43782a5 · 43782a5
1 parent 2d2da26
commit 43782a5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 - Syncing meta fields is no longer performed in a job.
 - Deprecated the `craft\shopify\jobs\UpdateProductMetadata` job.
 - Fixed a bug where the template routing setting would not save.
+- Removed `craft\shopify\events\ShopifyProductSyncEvent::$metafields`. Use `craft\shopify\events\ShopifyProductSyncEvent::$element->getMetaFields()` instead.
 
 ## 3.2.0 - 2023-06-12
 

diff --git a/src/services/Products.php b/src/services/Products.php
@@ -171,7 +171,6 @@ public function createOrUpdateProduct(ShopifyProduct $product, array $metafields
         $event = new ShopifyProductSyncEvent([
             'element' => $productElement,
             'source' => $product,
-            'metafields' => $metafields,
         ]);
         $this->trigger(self::EVENT_BEFORE_SYNCHRONIZE_PRODUCT, $event);