From dc7b70bfd74e3563b011b6e7f26851282b52d6a3 Mon Sep 17 00:00:00 2001
From: Bruce Bannon <brucebannon212@gmail.com>
Date: Sun, 3 Mar 2024 00:58:35 -0700
Subject: [PATCH 1/2] loops may not be the best option

sometimes for loops / foreach may be too much
---
 edit_report_handler.php | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)

diff --git a/edit_report_handler.php b/edit_report_handler.php
index b4d2575b7..52c72587b 100644
--- a/edit_report_handler.php
+++ b/edit_report_handler.php
@@ -150,24 +150,13 @@
     $names[] = 'cal_report_id';
     $values[] = $newid;
 
-    $sql = 'INSERT INTO webcal_report ( ';
-    $sql_v = '';
-
-    $namecnt = count ( $names );
-    for ( $i = 0; $i < $namecnt; $i++ ) {
-      $sql .= ( $i > 0 ? ', ' : '' ) . $names[$i];
-      $sql_v .= ( $i > 0 ? ', ' : '' ) . '?';
-    }
-    $sql .= ' ) VALUES ( ' . $sql_v . ' )';
+    $sql = 'INSERT INTO webcal_report ( ' . implode ( ',', $names )
+     . ' ) VALUES ( ?' . str_repeat ( ',?', count ( $names ) - 1 ) . ' )';
     $report_id = $newid;
   } else {
-    $sql = 'UPDATE webcal_report SET ';
-    $namecnt = count ( $names );
-    for ( $i = 0; $i < $namecnt; $i++ ) {
-      $sql .= ( $i > 0 ? ', ' : '' ) . "$names[$i] = ?";
-    }
-    $sql .= ' WHERE cal_report_id = ?';
-    $values[] = $report_id; // Push the $report_id to $values.
+    $sql = 'UPDATE webcal_report SET ' . implode ( ' = ?,', $names )
+     . ' = ? WHERE cal_report_id = ?';
+    $values[] = $report_id;
   }
 }
 

From 527c90da994228a6214707d0b0d7d99e97d70369 Mon Sep 17 00:00:00 2001
From: Bruce Bannon <brucebannon212@gmail.com>
Date: Sun, 14 Apr 2024 22:48:48 -0600
Subject: [PATCH 2/2] Why do it twice?

---
 autocomplete_ajax.php | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/autocomplete_ajax.php b/autocomplete_ajax.php
index 1b1714ca4..f05088188 100644
--- a/autocomplete_ajax.php
+++ b/autocomplete_ajax.php
@@ -115,12 +115,12 @@
   }
 
   $data = $sug = [];
-  for ($i = 0; $i < count ($ret); $i++) {
-    $sug[$i] = $ret[$i]['name'];
-  }
-  for ($i = 0; $i < count ($ret); $i++) {
-    $data[$i] = $ret[$i]['text'];
+
+  foreach ( $ret as $i ) {
+    $sug[]  = $i['name'];
+    $data[] = $i['text'];
   }
+
   ajax_send_object('matches', $sug, $sendPlainText);
 } else {
   ajax_send_error(translate("Error"));