I got carried away with sorting things #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigk5n
reviewed
Aug 31, 2023
| @@ -31,10 +31,10 @@ | |||
| require_once 'includes/validate.php'; | |||
|
|
|||
| // Load Doc classes for attachments and comments | |||
| require_once 'includes/classes/Doc.php'; | |||
| require_once 'includes/classes/DocList.php'; | |||
There was a problem hiding this comment.
We had a bug report about this order: #392
DocList requires Doc before it, right?
|
Does it? I didn't see an 'extends Doc.php' anywhere. Maybe I missed it.
…On Thu, Aug 31, 2023 at 7:01 AM Craig Knudsen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In events_ajax.php
<#397 (comment)>:
> @@ -31,10 +31,10 @@
require_once 'includes/validate.php';
// Load Doc classes for attachments and comments
-require_once 'includes/classes/Doc.php';
require_once 'includes/classes/DocList.php';
I believe we had a bug report about this order. DocList requires Doc
before it, right?
—
Reply to this email directly, view it on GitHub
<#397 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHJ7GLQNIEQ6FW2RATCGRE3XYCDLLANCNFSM6AAAAAA3T2E5CM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
The problem in DocList.php is this line: This requires Doc.php to be loaded first. |
|
Aha. I'm not really up on how classes work.
I think there are only a couple of places where doc.php should be relocated.
…On Tue, Sep 5, 2023 at 9:09 AM Craig Knudsen ***@***.***> wrote:
The problem in DocList.php is this line:
$sql = Doc::getSQL ( $event_id, $type );
This requires Doc.php to be loaded first.
—
Reply to this email directly, view it on GitHub
<#397 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHJ7GLXQMQKFFEMCARARAXTXY46A3ANCNFSM6AAAAAA3T2E5CM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Would it be be better, or work at all, if doclist.php required doc.php?
…On Tue, Sep 5, 2023 at 12:15 PM Bru Ba ***@***.***> wrote:
Aha. I'm not really up on how classes work.
I think there are only a couple of places where doc.php should be
relocated.
On Tue, Sep 5, 2023 at 9:09 AM Craig Knudsen ***@***.***>
wrote:
> The problem in DocList.php is this line:
>
> $sql = Doc::getSQL ( $event_id, $type );
>
> This requires Doc.php to be loaded first.
>
> —
> Reply to this email directly, view it on GitHub
> <#397 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AHJ7GLXQMQKFFEMCARARAXTXY46A3ANCNFSM6AAAAAA3T2E5CM>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move doclist.php back to the front