better versions of font-awesome and normalize.css #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it's failing the tests because composer.lock was not updated. Would't it be better to just let composer infer the latest compatible versions of these dependencies (i.e. "dependency management")? I don't understand the goal here... |
|
I ran composer require for component/font-awesome and
component/normalize.css
Those are better versions than the ones I did the first time.
When I did that, my other composer packages got auto updated.
I haven't had any problems, but I'm not completely sure yet
that newer versions of the other composer packages don't break webcalendar.
So, I left composer.lock out of the commit.
The goal is to start using some free icons from font awesome that are
smaller file size than what we have and look better.
There are also a couple thousand free options and I think we could let our
users decide which they like.
Also, to use normalize.css to make all browsers, especially edge and
symphony, start off with the same css 'defaults'.
Without updating styles.css very often.
…On Thu, Sep 14, 2023 at 7:50 AM Craig Knudsen ***@***.***> wrote:
Looks like it's failing the tests because composer.lock was not updated.
Would't it be better to just let composer infer the latest compatible
versions of these dependencies (i.e. "dependency management")? I don't
understand the goal here...
—
Reply to this email directly, view it on GitHub
<#412 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHJ7GLWE6AHKQKYTOF5SQN3X2MDSRANCNFSM6AAAAAA4XQADKU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
You need to include composer.json and compose.lock in the same PR for it to pass the tests. |
|
Ah. That explains a few things.
Is that only if package versions change?
Maybe you could just require those 2 packages on your end and see what
happens to the other packages.
…On Thu, Sep 14, 2023 at 12:40 PM Craig Knudsen ***@***.***> wrote:
You need to include composer.json and compose.lock in the same PR for it
to pass the tests.
—
Reply to this email directly, view it on GitHub
<#412 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHJ7GLTGS64AVUGIBKMB4MTX2NFQRANCNFSM6AAAAAA4XQADKU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the rest.
Not sure if that's a good thing.