Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most input -> button convertion #433

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Most input -> button convertion #433

merged 3 commits into from
Nov 21, 2023

Conversation

bbannon
Copy link
Contributor

@bbannon bbannon commented Nov 2, 2023

Since Craig is rewriting install/index.php, I didn't do those. But, I think I got the rest of converting <input> to <button>

@bbannon
Copy link
Contributor Author

bbannon commented Nov 18, 2023

This really has nothing to do with buttons, but I didn't want to reopen an old pr.

Isn't phpunit a debug tool for developers? Do end users need a copy of it from composer?

Also, I'm beginning to see the advantages of moving all the source files into 'webcalendar/source/' for devs to work on.
Then copying ONLY the files end users need, ALL minified (except *.txt files for the moment), to 'webcalendar/dist/' to be packaged as the 'distro.zip' file. I've been testing that. It's really not very disruptive to have a couple of subfolders that 'the code' uses, but people won't really see. It would be a huge pr, but only once. And the distro.zip would be about half the current size. Even less if we can figure out how to copy only the various translation files, captcha/ckeditor/phpmailer/ours that each user actually needs.

@craigk5n
Copy link
Owner

End users don't need phpunit, and it's not included in the releases. Releases currently only include what is listed in release-files which does not include the "vendor" directory.

@craigk5n
Copy link
Owner

See release.yml to see how releases are created.

@bbannon
Copy link
Contributor Author

bbannon commented Nov 21, 2023

I asked because I don't see a version of composer.json that leaves out that line.

@craigk5n craigk5n merged commit f22b824 into craigk5n:master Nov 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants