Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish wikipedia links #215

Open
craigsapp opened this issue Apr 9, 2023 · 2 comments
Open

Polish wikipedia links #215

craigsapp opened this issue Apr 9, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@craigsapp
Copy link
Owner

When viewing the website in Polish, the Wikipedia link(s) for composers points to the English page rather than the Polish page.

Example:

Screenshot 2023-04-09 at 11 27 13

https://polishscores.org/?id=pl-wtm--r-283-m

In this case the "Wikipedia" link points to:
https://en.wikipedia.org/wiki/Stanis%C5%82aw_Moniuszko

Rather than
https://pl.wikipedia.org/wiki/Stanis%C5%82aw_Moniuszko

The spreadsheet contains the correct link:

Screenshot 2023-04-09 at 11 26 25

@craigsapp craigsapp added the enhancement New feature or request label Apr 9, 2023
@craigsapp craigsapp self-assigned this Apr 9, 2023
@craigsapp
Copy link
Owner Author

The Polish wikipedia links are correctly given in the composer index:

https://humdrum.nifc.pl/popc2-composer-index.aton
https://humdrum.nifc.pl/popc2-composer-index.json

@@BEGIN: ENTRY
@COM:			Moniuszko, Stanisław
@COM-rismID:		pe30008351
@Aliases:		
@Birth:			1819/05/05
@Death:			1872/06/04
@CDT:			1819/05/05-1872/06/04
@CNT:			Polish
@Gender:		M
@ID-COM-nifc:		4570
@URL-COM-nifc@PL:	https://portalmuzykipolskiej.pl/pl/osoba/4570-Stanislaw-Moniuszko
@URL-COM-nifc@EN:	https://portalmuzykipolskiej.pl/en/osoba/4570-Stanislaw-Moniuszko
@URL-COM-wikipedia@PL:	https://pl.wikipedia.org/wiki/Stanis%C5%82aw_Moniuszko
@URL-COM-wikipedia@EN:	https://en.wikipedia.org/wiki/Stanis%C5%82aw_Moniuszko
@URL-COM-wikipedia:	
@VIAF:			66653621
@URL-COM-worldcat:	
@URL-COM-wikidata:	http://www.wikidata.org/entity/Q217613
@URL-COM-imslp:		https://imslp.org/wiki/Category:Moniuszko%2C_Stanis%C5%82aw
@URL-COM-cpdl:		
@Portrait:		https://upload.wikimedia.org/wikipedia/commons/thumb/4/41/Stanis%C5%82a%C5%AD_Maniu%C5%A1ka._%D0%A1%D1%82%D0%B0%D0%BD%D1%96%D1%81%D0%BB%D0%B0%D1%9E_%D0%9C%D0%B0%D0%BD%D1%8E%D1%88%D0%BA%D0%B0_%28T._Maleszewski%2C_1865%29.jpg/340px-Stanis%C5%82a%C5%AD_Maniu%C5%A1ka._%D0%A1%D1%82%D0%B0%D0%BD%D1%96%D1%81%D0%BB%D0%B0%D1%9E_%D0%9C%D0%B0%D0%BD%D1%8E%D1%88%D0%BA%D0%B0_%28T._Maleszewski%2C_1865%29.jpg
@Other_url:		
@POPC2_IMAGE:		moniuszko.png
@Bio:			1
@@END: ENTRY
	{
		"COM": "Moniuszko, Stanisław",
		"COM-rismID": "pe30008351",
		"Aliases": "",
		"Birth": "1819/05/05",
		"Death": "1872/06/04",
		"CDT": "1819/05/05-1872/06/04",
		"CNT": "Polish",
		"Gender": "M",
		"ID-COM-nifc": "4570",
		"URL-COM-nifc@PL": "https://portalmuzykipolskiej.pl/pl/osoba/4570-Stanislaw-Moniuszko",
		"URL-COM-nifc@EN": "https://portalmuzykipolskiej.pl/en/osoba/4570-Stanislaw-Moniuszko",
		"URL-COM-wikipedia@PL": "https://pl.wikipedia.org/wiki/Stanis%C5%82aw_Moniuszko",
		"URL-COM-wikipedia@EN": "https://en.wikipedia.org/wiki/Stanis%C5%82aw_Moniuszko",
		"URL-COM-wikipedia": "",
		"VIAF": "66653621",
		"URL-COM-worldcat": "",
		"URL-COM-wikidata": "http://www.wikidata.org/entity/Q217613",
		"URL-COM-imslp": "https://imslp.org/wiki/Category:Moniuszko%2C_Stanis%C5%82aw",
		"URL-COM-cpdl": "",
		"Portrait": "https://upload.wikimedia.org/wikipedia/commons/thumb/4/41/Stanis%C5%82a%C5%AD_Maniu%C5%A1ka._%D0%A1%D1%82%D0%B0%D0%BD%D1%96%D1%81%D0%BB%D0%B0%D1%9E_%D0%9C%D0%B0%D0%BD%D1%8E%D1%88%D0%BA%D0%B0_%28T._Maleszewski%2C_1865%29.jpg/340px-Stanis%C5%82a%C5%AD_Maniu%C5%A1ka._%D0%A1%D1%82%D0%B0%D0%BD%D1%96%D1%81%D0%BB%D0%B0%D1%9E_%D0%9C%D0%B0%D0%BD%D1%8E%D1%88%D0%BA%D0%B0_%28T._Maleszewski%2C_1865%29.jpg",
		"Other_url": "",
		"POPC2_IMAGE": "moniuszko.png",
		"Bio": "1"
	},

And in the final composer index on the webpage:

Screenshot 2023-04-09 at 13 55 15

So it is a javascript problem.

@craigsapp
Copy link
Owner Author

The problem is if you change the language on the work page, the Wikipedia link's language will not be updated. If you start from the browse page in Polish, then the wikipedia link is Polish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant