Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB/SB when using --breaks original #278

Closed
craigsapp opened this issue Feb 11, 2024 · 4 comments
Closed

PB/SB when using --breaks original #278

craigsapp opened this issue Feb 11, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@craigsapp
Copy link
Owner

When verovio uses the option --breaks original, page breaks will force pagination of the rendered score, and the full score cannot be seen on a long single page as an SVG. More proper on the single-page display on polishscores.org (but preserving original system breaks), the option --breaks line should be used. This will convert original page breaks into system breaks.

@craigsapp craigsapp added the enhancement New feature or request label Feb 11, 2024
@craigsapp craigsapp self-assigned this Feb 11, 2024
craigsapp added a commit that referenced this issue Feb 11, 2024
@craigsapp
Copy link
Owner Author

craigsapp commented Feb 11, 2024

Implemented with commit 7c85362

Now the entire score is shown when the "Original system breaks" option is selected in the configuration panel:

https://polishscores.org/?id=18xx:3901&con=Ob

Screenshot 2024-02-11 at 15 35 58

(before it was stopping at measure 11)

Some line breaks are missing in this score:

Extra line break added at measure 15:

Screenshot 2024-02-11 at 15 40 43

Which was probably supposed to be added at the start of measure 18:

Screenshot 2024-02-11 at 15 41 37

The last page does not have line breaks:

Screenshot 2024-02-11 at 15 42 32

Probably related to issue #277, where the last page of the source is missing (and the encode added from another source but did not encode the system breaks.

VHV link to score: https://verovio.humdrum.org/?file=https:%2F%2Fhumdrum.nifc.pl%2F18xx:3901.krn

@jacekiwaszko1
Copy link
Collaborator

Some line breaks are missing in this score:

It looks like the XML editor used a different source to fill in the missing parts, and the Humdrum editor skipped it. I fixed the encoding and pushed the changes to our local repository.

@craigsapp
Copy link
Owner Author

OK, I will update publications of the scores (sooner or later).

@craigsapp
Copy link
Owner Author

craigsapp commented Feb 12, 2024

Note a correction to LO:LB in issue (towards the end of the second post): #282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants