Daikin: Support setting temperature in 0.5 C unit #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daikin 280-bit A/C protocol can set the temperature in 0.5 C unit. However, IRDaikinESP didn't support it. This PR allows to set and get the temperature in 0.5 C unit. It looks like some other Daikin protocols also support setting the temperature in 0.5 C unit: * Daikin2 * Daikin216 * Daikin160 * Daikin176 * Daikin152 However, they are not implemented in this PR, because I cannot test them.
k-takata
force-pushed
the
daikin-support-0.5C
branch
from
673e374 to
26fe9bb
Compare
crankyoldgit
requested changes
Dec 9, 2023
src/ir_Daikin.h
Outdated
| @@ -99,8 +99,7 @@ union DaikinESPProtocol{ | |||
| uint64_t Mode :3; | |||
| uint64_t :1; | |||
| // Byte 22 | |||
| uint64_t :1; | |||
| uint64_t Temp :7; // Temp should be between 10 - 32 | |||
| uint64_t Temp2 :8; // Temp2 should be between 20 - 64 (10 C - 32 C) | |||
There was a problem hiding this comment.
Please keep it as Temp, not Temp2
src/ir_Daikin.cpp
Outdated
| void IRDaikinESP::setTemp(const float temp) { | ||
| float degrees = std::max(temp, static_cast<float>(kDaikinMinTemp)); | ||
| degrees = std::min(degrees, static_cast<float>(kDaikinMaxTemp)); | ||
| _.Temp2 = degrees * 2.0f; |
src/ir_Daikin.cpp
Outdated
| } | ||
|
|
||
| /// Get the current temperature setting. | ||
| /// @return The current setting for temp. in degrees celsius. | ||
| uint8_t IRDaikinESP::getTemp(void) const { return _.Temp; } | ||
| float IRDaikinESP::getTemp(void) const { return _.Temp2 / 2.0f; } |
src/ir_Daikin.cpp
Outdated
| @@ -563,7 +564,7 @@ String IRDaikinESP::toString(void) const { | |||
| result += addBoolToString(_.Power, kPowerStr, false); | |||
| result += addModeToString(_.Mode, kDaikinAuto, kDaikinCool, kDaikinHeat, | |||
| kDaikinDry, kDaikinFan); | |||
| result += addTempToString(_.Temp); | |||
| result += addTempFloatToString(_.Temp2 / 2.0f); | |||
There was a problem hiding this comment.
Use:
result += addTempFloatToString(getTemp());* Use `Temp`, not `Temp2`. * Use `getTemp()`.
|
Thank you for the review. Updated as suggested. |
crankyoldgit
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Daikin 280-bit A/C protocol can set the temperature in 0.5 C unit. However, IRDaikinESP didn't support it.
This PR allows to set and get the temperature in 0.5 C unit.
It looks like some other Daikin protocols also support setting the temperature in 0.5 C unit:
However, they are not implemented in this PR, because I cannot test them.