MongoDB: Code refactoring and generalization #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
mongodb-full-next
branch
4 times, most recently
from
3da5315
to
5befd3e
Compare
amotl
force-pushed
the
mongodb-full-next
branch
from
5befd3e
to
d204434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
The
MongoDBFullLoadTranslatorhas been generalized on behalf of recent improvements to cratedb-toolkit already. This patch just slots it into the right place to make it reusable, and also makes theMongoDBCDCTranslatoruse the improved decoding machinery. Along the lines, the patch fixes a little issue with Zyp Transformations and exercises another use case.Details
MongoDBFullLoadTranslatorandMongoDBCrateDBConverterbsonpackage to parse BSON CANONICAL representationMongoDBCDCTranslatorReferences
commons-codeccratedb-toolkit#269