You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The crash repository currently manages its fragment of the crate namespace package within a top-level folder. It should probably use the "src layout", like crate-python is also doing it, storing the actual module's source under src/crate/.
The “src layout” deviates from the flat layout by moving the code that is intended to be importable into a subdirectory. This subdirectory is typically named src/, hence “src layout”.
The src layout helps prevent accidental usage of the in-development copy of the code.
In previous times of Python packaging, and when using the previous variants of implementing namespace packages, this detail probably didn't play a relevant role. Now, apparently, it does, and needs a minor refactoring of the directory layout.
Problem
After upgrading to crate-1.0.0 (dev), running the testsuite using
python -m unittest -vvv
trips, not able to findcrate.client
any longer.crate-1.0.0.dev2
to support final GA testing #446This is probably coming from the transition to "implicit namespace packages".
Observations
The problem does not happen at runtime, so we are safe on this side at least.
uv pip install --upgrade "crate>=1.0.0.dev2" crash $ crash --version 0.31.5
Solution
The crash repository currently manages its fragment of the
crate
namespace package within a top-level folder. It should probably use the "src layout", like crate-python is also doing it, storing the actual module's source undersrc/crate/
.-- https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/
Evaluation
In previous times of Python packaging, and when using the previous variants of implementing namespace packages, this detail probably didn't play a relevant role. Now, apparently, it does, and needs a minor refactoring of the directory layout.
/cc @surister, @simonprickett, @kneth
The text was updated successfully, but these errors were encountered: