Dependencies: Remove version pinning of urllib3 and verlib2 #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
dependencies-no-version-pinning
branch
from
d033fb1
to
419463a
Compare
amotl
changed the title
seut
approved these changes
Nov 4, 2024
kneth
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
A library mostly shouldn't apply version pinning when not exactly needed. Only applications usually do, and libraries should be able to cope with different up- and downstream-versions.
Considering that both runtime dependencies are stable on their own, this should not cause too many forseeable headaches. When urllib3 v3 will be released, it might be different, but honestly I can't imagine it will be breaking its designated interface too much, if at all.