Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataframes: Refactor examples about pandas and Dask #265

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Feb 6, 2024

About

Two examples about pandas and Dask have been added to the by-language/python-sqlalchemy folder beforehand. This patch refactors them into the by-dataframe/{pandas,dask} folders.

/cc @hlcianfagna, @wierdvanderhaar, @marijaselakovic

@amotl amotl force-pushed the amo/df-pandas-dask branch 4 times, most recently from bd7a297 to d9f5238 Compare February 6, 2024 15:50
@amotl amotl marked this pull request as ready for review February 6, 2024 15:52
@amotl amotl requested review from karynzv and removed request for marijaselakovic and matkuliak February 6, 2024 16:20
@marijaselakovic
Copy link
Contributor

The restructuring makes sense, I don't have more comments to add.


## Usage

The CrateDB Python driver provides a convenience function `insert_bulk`. It
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to add: insert_bulk allows you to efficiently insert multiple rows of data into a CrateDB table in a single operation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good suggestion. I've just amended the patch accordingly. Thanks.

@amotl amotl merged commit 99a8c5d into main Feb 6, 2024
6 checks passed
@amotl amotl deleted the amo/df-pandas-dask branch February 6, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants