Switch to new SQLAlchemy dialect for CrateDB

This includes the fix to the `get_table_names()` reflection method.
crate · Dec 22, 2023 · 500e343 · 500e343
1 parent 0f39ebd
commit 500e343
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 40 deletions.
diff --git a/cratedb_toolkit/sqlalchemy/patch.py b/cratedb_toolkit/sqlalchemy/patch.py
diff --git a/cratedb_toolkit/util/database.py b/cratedb_toolkit/util/database.py
@@ -211,7 +211,7 @@ def import_csv_pandas(
         Import CSV data using pandas.
         """
         import pandas as pd
-        from crate.client.sqlalchemy.support import insert_bulk
+        from sqlalchemy_cratedb.support import insert_bulk
 
         df = pd.read_csv(filepath)
         with self.engine.connect() as connection:
@@ -234,7 +234,7 @@ def import_csv_dask(
         """
         import dask.dataframe as dd
         import pandas as pd
-        from crate.client.sqlalchemy.support import insert_bulk
+        from sqlalchemy_cratedb.support import insert_bulk
 
         # Set a few defaults.
         npartitions = npartitions or os.cpu_count()

diff --git a/pyproject.toml b/pyproject.toml
@@ -90,11 +90,10 @@ dependencies = [
   "colorama<1",
   "colorlog",
   "crash",
-  "crate[sqlalchemy]>=0.34",
   "croud==1.8",
   'importlib-metadata; python_version <= "3.7"',
   "python-dotenv<2",
-  "sqlalchemy",
+  "sqlalchemy-cratedb@ git+https://github.com/crate-workbench/sqlalchemy-cratedb.git@amo/fix-inspector",
   "sqlparse<0.5",
 ]
 [project.optional-dependencies]

diff --git a/tests/sqlalchemy/test_patch.py b/tests/sqlalchemy/test_patch.py
@@ -1,6 +1,5 @@
 import sqlalchemy as sa
 
-from cratedb_toolkit.sqlalchemy import patch_inspector
 from tests.conftest import TESTDRIVE_DATA_SCHEMA
 
 
@@ -32,7 +31,6 @@ def test_inspector_patched(database):
     This verifies that it still works, when it properly has been assigned to
     the `?schema=` connection string URL parameter.
     """
-    patch_inspector()
     tablename = f'"{TESTDRIVE_DATA_SCHEMA}"."foobar"'
     inspector: sa.Inspector = sa.inspect(database.engine)
     database.run_sql(f"CREATE TABLE {tablename} AS SELECT 1")