Skip to content

Commit

Permalink
MongoDB/PyMongo: Naming things
Browse files Browse the repository at this point in the history
Use `PyMongoCrateDBAdapter`, with capitalized "DB".
  • Loading branch information
amotl committed Jul 6, 2024
1 parent 44aba7a commit f808598
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 15 deletions.
5 changes: 3 additions & 2 deletions cratedb_toolkit/adapter/pymongo/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@ docker run --rm -it --name=cratedb \


## Synopsis

```python
import pymongo
from cratedb_toolkit.adapter.pymongo import PyMongoCrateDbAdapter
from cratedb_toolkit.adapter.pymongo import PyMongoCrateDBAdapter

with PyMongoCrateDbAdapter(dburi="crate://crate@localhost:4200"):
with PyMongoCrateDBAdapter(dburi="crate://crate@localhost:4200"):
client = pymongo.MongoClient("localhost", 27017)
collection = client.foo.bar

Expand Down
2 changes: 1 addition & 1 deletion cratedb_toolkit/adapter/pymongo/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
from .api import PyMongoCrateDbAdapter # noqa: F401
from .api import PyMongoCrateDBAdapter # noqa: F401
2 changes: 1 addition & 1 deletion cratedb_toolkit/adapter/pymongo/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
patch_types_map()


class PyMongoCrateDbAdapter:
class PyMongoCrateDBAdapter:
"""
Patch PyMongo to talk to CrateDB.
"""
Expand Down
4 changes: 2 additions & 2 deletions examples/pymongo_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
import pymongo
from pymongo.database import Database

from cratedb_toolkit.adapter.pymongo import PyMongoCrateDbAdapter
from cratedb_toolkit.adapter.pymongo import PyMongoCrateDBAdapter
from cratedb_toolkit.util.common import setup_logging

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -109,7 +109,7 @@ def main(dburi: str = None):
setup_logging(level=logging.INFO, width=20)

# Context manager use.
with PyMongoCrateDbAdapter(dburi=dburi):
with PyMongoCrateDBAdapter(dburi=dburi):
mongodb_workload()


Expand Down
18 changes: 9 additions & 9 deletions tests/adapter/test_pymongo.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

check_sqlalchemy1(allow_module_level=True)

from cratedb_toolkit.adapter.pymongo import PyMongoCrateDbAdapter
from cratedb_toolkit.adapter.pymongo import PyMongoCrateDBAdapter
from cratedb_toolkit.adapter.pymongo.util import AmendedObjectId
from cratedb_toolkit.util.date import truncate_milliseconds
from tests.conftest import TESTDRIVE_DATA_SCHEMA
Expand All @@ -25,7 +25,7 @@ def pymongo_cratedb(cratedb):
"""
Enable the PyMongo -> CrateDB adapter.
"""
with PyMongoCrateDbAdapter(dburi=cratedb.database.dburi) as adapter:
with PyMongoCrateDBAdapter(dburi=cratedb.database.dburi) as adapter:
yield adapter


Expand Down Expand Up @@ -53,7 +53,7 @@ def refresh():
return refresh


def test_pymongo_metadata(pymongo_cratedb: PyMongoCrateDbAdapter, pymongo_client: pymongo.MongoClient):
def test_pymongo_metadata(pymongo_cratedb: PyMongoCrateDBAdapter, pymongo_client: pymongo.MongoClient):
"""
Verify attribute access to the database and collection handles works well.
"""
Expand All @@ -69,7 +69,7 @@ def test_pymongo_metadata(pymongo_cratedb: PyMongoCrateDbAdapter, pymongo_client


def test_pymongo_insert_one_single(
pymongo_cratedb: PyMongoCrateDbAdapter,
pymongo_cratedb: PyMongoCrateDBAdapter,
pymongo_client: pymongo.MongoClient,
cratedb: CrateDBTestAdapter,
sync_writes,
Expand All @@ -95,7 +95,7 @@ def test_pymongo_insert_one_single(


def test_pymongo_insert_one_multiple(
pymongo_cratedb: PyMongoCrateDbAdapter,
pymongo_cratedb: PyMongoCrateDBAdapter,
pymongo_client: pymongo.MongoClient,
cratedb: CrateDBTestAdapter,
sync_writes,
Expand Down Expand Up @@ -125,7 +125,7 @@ def test_pymongo_insert_one_multiple(


def test_pymongo_insert_many(
pymongo_cratedb: PyMongoCrateDbAdapter,
pymongo_cratedb: PyMongoCrateDBAdapter,
pymongo_client: pymongo.MongoClient,
cratedb: CrateDBTestAdapter,
sync_writes,
Expand Down Expand Up @@ -154,7 +154,7 @@ def test_pymongo_insert_many(


def test_pymongo_count_documents(
pymongo_cratedb: PyMongoCrateDbAdapter,
pymongo_cratedb: PyMongoCrateDBAdapter,
pymongo_client: pymongo.MongoClient,
cratedb: CrateDBTestAdapter,
sync_writes,
Expand All @@ -180,7 +180,7 @@ def test_pymongo_count_documents(


def test_pymongo_roundtrip_document(
pymongo_cratedb: PyMongoCrateDbAdapter,
pymongo_cratedb: PyMongoCrateDBAdapter,
pymongo_client: pymongo.MongoClient,
cratedb: CrateDBTestAdapter,
sync_writes,
Expand Down Expand Up @@ -240,7 +240,7 @@ def test_example_program(cratedb: CrateDBTestAdapter):


def test_pymongo_tutorial(
pymongo_cratedb: PyMongoCrateDbAdapter,
pymongo_cratedb: PyMongoCrateDBAdapter,
pymongo_client: pymongo.MongoClient,
cratedb: CrateDBTestAdapter,
sync_writes,
Expand Down

0 comments on commit f808598

Please sign in to comment.