Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging: Use cloud extra to install relevant packages #101

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Jan 19, 2024

About

Don't install croud by default. It will not work on Python 3.7.

References

I.e., don't always install the `croud` package.
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6343c73) 84.93% compared to head (49e4838) 84.82%.

Files Patch % Lines
cratedb_toolkit/cluster/util.py 66.66% 2 Missing ⚠️
cratedb_toolkit/util/croud.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   84.93%   84.82%   -0.11%     
==========================================
  Files          48       48              
  Lines        1805     1812       +7     
==========================================
+ Hits         1533     1537       +4     
- Misses        272      275       +3     
Flag Coverage Δ
influxdb 41.33% <42.85%> (-1.33%) ⬇️
main 66.83% <64.28%> (-0.15%) ⬇️
mongodb 55.90% <42.85%> (-1.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl marked this pull request as ready for review January 19, 2024 21:40
@amotl amotl merged commit 1469873 into main Jan 19, 2024
20 checks passed
@amotl amotl deleted the amo/croud-to-cloud branch January 19, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant