Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Unpin upper version bound of dask #135

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

amotl
Copy link
Member

@amotl amotl commented Apr 9, 2024

Otherwise, compatibility issues can not be resolved quickly, like with
Python 3.11.9.
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.92%. Comparing base (6fb3bd2) to head (4da15ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   78.92%   78.92%           
=======================================
  Files          56       56           
  Lines        1969     1969           
=======================================
  Hits         1554     1554           
  Misses        415      415           
Flag Coverage Δ
influxdb 35.60% <ø> (ø)
main 62.11% <ø> (ø)
mongodb 49.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl
Copy link
Member Author

amotl commented Apr 9, 2024

The package selects dask 2024.3.1, because dask-expr 1.0.5 says so.

pip install --upgrade dask

dask-expr 1.0.5 requires dask==2024.3.1, but you have dask 2024.4.1 which is incompatible.

However, selecting dask 2024.3.1 on the most recent Python 3.11 is a bad idea, as we know from pycaret/pycaret#3960 (comment).

TypeError: descriptor '__call__' for 'type' objects doesn't apply to a 'property' object

-- https://github.com/crate-workbench/cratedb-toolkit/actions/runs/8621823379/job/23631548577?pr=135#step:5:131

This unpins the upper version bound of `dask` in `influxio`.
@amotl amotl marked this pull request as ready for review April 10, 2024 01:57
@amotl amotl merged commit 59450da into main Apr 10, 2024
18 checks passed
@amotl amotl deleted the amo/fix-dask-unpin branch April 10, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants