Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Add pytest fixtures to discriminate between SQLAlchemy 1 and 2 #185

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Jul 6, 2024

About

Broken away from GH-83. Makes running tests on both SQLAlchemy 1 and SQLAlchemy 2 easier, because the test cases now know what is acceptable for them.

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.35%. Comparing base (8bbbaff) to head (dc8ebc1).

❗ There is a different number of reports uploaded between BASE (8bbbaff) and HEAD (dc8ebc1). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (8bbbaff) HEAD (dc8ebc1)
mongodb 10 0
influxdb 4 0
main 4 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #185       +/-   ##
===========================================
- Coverage   81.17%   69.35%   -11.82%     
===========================================
  Files          73       73               
  Lines        2826     2826               
===========================================
- Hits         2294     1960      -334     
- Misses        532      866      +334     
Flag Coverage Δ
influxdb ?
main 69.35% <ø> (ø)
mongodb ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl marked this pull request as ready for review July 6, 2024 15:59
@amotl amotl merged commit 2851bb7 into main Jul 6, 2024
7 checks passed
@amotl amotl deleted the amo/testing-sa1-sa2 branch July 6, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant