Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFR: Upload application bundle artifacts to GitHub Pages #192

Closed
wants to merge 2 commits into from

Conversation

amotl
Copy link
Member

@amotl amotl commented Jul 7, 2024

Problem

Uploading on PRs to GitHub Workflow Artifacts is not enough, because it does not provide good UX for downloading purposes.

About

This patch extends the GHA workflow to additionally upload to GitHub Pages.

References

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.01%. Comparing base (3b5f012) to head (13d1502).

❗ There is a different number of reports uploaded between BASE (3b5f012) and HEAD (13d1502). Click for more details.

HEAD has 14 uploads less than BASE
Flag BASE (3b5f012) HEAD (13d1502)
influxdb 4 0
mongodb 10 0
Additional details and impacted files
@@               Coverage Diff                @@
##           s/cfr-binary     #192      +/-   ##
================================================
- Coverage         81.73%   72.01%   -9.72%     
================================================
  Files                79       79              
  Lines              3213     3213              
================================================
- Hits               2626     2314     -312     
- Misses              587      899     +312     
Flag Coverage Δ
influxdb ?
main 59.97% <ø> (ø)
mongodb ?
pymongo 42.35% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl force-pushed the amo/cfr-pages branch 3 times, most recently from f68edf5 to 61088b7 Compare July 7, 2024 00:44
@amotl
Copy link
Member Author

amotl commented Jul 7, 2024

GitHub Pages is not a very good upload destination, because artifacts/resources will be added to the repository itself by default, into a branch called gh-pages. Because the total payload size already is 4x ~100 MB, this would blow up the repository size too much, and already gets rejected by default:

remote: error: File tmp/linux-x64/cratedb-cfr is 126.43 MB; this exceeds GitHub's file size limit of 100.00 MB        
remote: error: GH001: Large files detected. You may want to try Git Large File Storage - https://git-lfs.github.com./

-- https://github.com/crate-workbench/cratedb-toolkit/actions/runs/9823563563/job/27121581872#step:10:77

@amotl amotl closed this Jul 7, 2024
@amotl amotl deleted the amo/cfr-pages branch July 7, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant