Core: Improve quoting for TableAddress.fullname
#202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/refactor-tablename-quoting
branch
from
155fe10
to
68e1883
Compare
2 tasks
By making the canonical `DatabaseAdapter.quote_relation_name` static, it can be used by `TableAddress.fullname` now. This makes table name quoting less fragmented across the code base.
amotl
force-pushed
the
amo/refactor-tablename-quoting
branch
from
68e1883
to
df4cdaf
Compare
surister
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Just a bit of refactoring and infrastructure improvements.
Details
By making the canonical
DatabaseAdapter.quote_relation_namestatic, it can be used byTableAddress.fullnamenow.This makes table name quoting less fragmented across the code base.
References
ctk load table: Add support for MongoDB Change Streams #196 (comment)Notes
We need it for GH-196, and we need to ship it. Please add your voice retroactively, so we can consider any admonitions from your pen even after this has been merged already. Thank you!