DynamoDB: Change CrateDB data model to use (pk, data, aux) columns
#281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
dynamodb-fix-cdc
branch
2 times, most recently
from
a07a456
to
c67bb5c
Compare
hammerhead
reviewed
Sep 30, 2024
cratedb_toolkit/io/dynamodb/copy.py
Outdated
| logger.info(f"Source: DynamoDB table={self.dynamodb_table} count={records_in}") | ||
|
|
||
| # FIXME! |
There was a problem hiding this comment.
Do we need a comment here on what is open to be fixed? At least I wouldn't know.
There was a problem hiding this comment.
It was an accident / leftover. I just removed it. Thanks for spotting it.
hammerhead
approved these changes
Sep 30, 2024
amotl
force-pushed
the
dynamodb-fix-cdc
branch
2 times, most recently
from
8925ca0
to
2c9995b
Compare
By breaking the primary key information out of the main record's data bucket, the main record can be updated as-is on CDC MODIFY operations.
amotl
force-pushed
the
dynamodb-fix-cdc
branch
from
2c9995b
to
c4e36b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
By breaking the primary key information out of the main record's data bucket, the main record can be updated as-is on CDC MODIFY operations.
References
pk,data,aux) columns commons-codec#64