MongoDB: Add code from migr8 program
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
amotl
force-pushed
the
amo/mongodb
branch
2 times, most recently
from
67c8c1c
to
f5aef18
Compare
amotl
changed the title
migr8 program from previous repositorymigr8 program from previous repository
amotl
force-pushed
the
amo/generalize-testcontainers
branch
2 times, most recently
from
725fd28
to
1c49f92
Compare
amotl
commented
Nov 12, 2023
Comment on lines
+35
to
+47
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: ["ubuntu-latest"] | ||
| python-version: ["3.8", "3.12"] | ||
| mongodb-version: ["2", "3", "4", "5", "6", "7"] | ||
|
|
||
| env: | ||
| OS: ${{ matrix.os }} | ||
| PYTHON: ${{ matrix.python-version }} | ||
| MONGODB_VERSION: ${{ matrix.mongodb-version }} | ||
| # Do not tear down Testcontainers | ||
| TC_KEEPALIVE: true |
There was a problem hiding this comment.
It looks like MONGODB_VERSION may not be picked up by the test suite here, yet. By default, it is mongo:latest 1.
Footnotes
There was a problem hiding this comment.
MongoDbContainerWithKeepalive has been improved correspondingly, and split into a seperate commit, see bf156ef.
amotl
changed the title
migr8 program from previous repositorymigr8 program
amotl
force-pushed
the
amo/mongodb
branch
2 times, most recently
from
2a0d819
to
173a645
Compare
It honors the `TC_KEEPALIVE` and `MONGODB_VERSION` environment variables. Defining `TC_KEEPALIVE` will set a signal not to shut down the container after running the test cases, in order to speed up subsequent invocations. `MONGODB_VERSION` will define the designated MongoDB version, which is useful when used within a test matrix. Its default value is `latest`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
The
migr8program has been maintained over at 1. This patch adds it to cratedb-toolkit instead, in order to streamline maintenance in terms of more regular testing and shipping.Details
Documentation is included. Installation works like:
pip install 'cratedb-toolkit[io]' migr8 --helpA different CLI/library interface will be added on behalf of a subsequent iteration.
/cc @karynzv
Footnotes
https://github.com/crate/mongodb-cratedb-migration-tool ↩