Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data loading: Refactor to use more OO. Add examples/cloud_import.py. #80

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 13, 2023

  • Data loading: Refactor to use more OO.
  • Data model, naming things, error handling, croud workarounds.
  • Add examples/cloud_import.py.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Files Coverage Δ
cratedb_toolkit/cluster/cli.py 73.91% <100.00%> (ø)
cratedb_toolkit/exception.py 100.00% <100.00%> (+100.00%) ⬆️
cratedb_toolkit/model.py 77.41% <83.33%> (-20.70%) ⬇️
cratedb_toolkit/retention/store.py 25.17% <0.00%> (-69.72%) ⬇️
cratedb_toolkit/api/guide.py 50.00% <50.00%> (ø)
cratedb_toolkit/util/croud.py 31.86% <37.50%> (-37.10%) ⬇️
cratedb_toolkit/io/cli.py 83.72% <61.11%> (-0.28%) ⬇️
cratedb_toolkit/io/croud.py 17.89% <22.22%> (-67.22%) ⬇️
cratedb_toolkit/api/main.py 51.42% <51.42%> (ø)

... and 17 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@amotl amotl marked this pull request as ready for review November 13, 2023 21:02
@amotl amotl merged commit 037b8bb into main Nov 13, 2023
19 of 20 checks passed
@amotl amotl deleted the amo/more-oo branch November 13, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant