add dns server to ovs-if-br-ex nm connection #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkumar
reviewed
Oct 8, 2024
| systemctl restart NetworkManager | ||
| stop_if_failed $? "failed to restart NetworkManager" | ||
| } | ||
|
|
There was a problem hiding this comment.
when I was testing this last week (and that's the reason I didn't put PR) is as soon as Network restart happen and then we start kubelet somehow it again trigger ovs-configuration.service and it fails :( do test this scenario once.
There was a problem hiding this comment.
ahh, but this is working on crc somehow? maybe we just need to down/up the connection instead of restarting NetworkManager service?
since crc bundles switched to IPI with SNO configutation default cni network plugin is ovn-k which creates this a bridge device in the VM and a network manager connection to manage it, the DNS configuration need to be added to this connection
anjannath
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since crc bundles switched to IPI with SNO
configutation default cni network plugin is
ovn-k which creates this a bridge device in
the VM and a network manager connection to
manage it, the DNS configuration need to be
added to this connection
this tries to incorporate the changes that were done in: crc-org/crc@60040cd and crc-org/crc@2b23a06 for
crc