Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added README information for usage of crc-cloud based on pulumi. #35

Merged
merged 1 commit into from
Mar 1, 2023
Merged

added README information for usage of crc-cloud based on pulumi. #35

merged 1 commit into from
Mar 1, 2023

Conversation

adrianriobo
Copy link
Contributor

this PR will introduce specific information on how to operate with crc-cloud container images for crc-cloud based on pulumi implementation

@praveenkumar
Copy link
Member

@lmilbaum , @tsebastiani Can you please review those changes it consist of how to run crc-cloud in the container after migrating to pulumi. Container images are already available so you might need to just test it with your CI steps.

@lmilbaum
Copy link
Contributor

lmilbaum commented Feb 7, 2023 •
edited
Loading

Can't test this PR. I am blocked because it doesn't support the region I am working with eu-west-2. What are the required steps to support another region? [posted the same question over Slack]

@adrianriobo adrianriobo mentioned this pull request Feb 7, 2023
Merged
lmilbaum
lmilbaum requested changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@lmilbaum lmilbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the file arguments (pull secret and key) to in-memory ones? The file content is a secret. I would like to avoid manipulating the secrets before the environment is spinned. Take a look at the following PR - platform-engineering-org/poc#93

@adrianriobo
Copy link
Contributor Author

adrianriobo commented Feb 17, 2023 •
edited
Loading

Add general information on auth mechanisms for AWS inherit from pulumi so from AWS itself.

yerdreic
yerdreic reviewed Feb 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@adrianriobo adrianriobo force-pushed the pulumi_readme branch 2 times, most recently from 9667039 to 2336778 Compare February 23, 2023 18:09
@praveenkumar
Copy link
Member

/lgtm

@praveenkumar praveenkumar merged commit 31a4e91 into crc-org:pulumi Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yerdreic yerdreic yerdreic left review comments

@praveenkumar praveenkumar praveenkumar left review comments

@lmilbaum lmilbaum lmilbaum requested changes

@tsebastiani tsebastiani Awaiting requested review from tsebastiani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianriobo @praveenkumar @lmilbaum @yerdreic