crc-cloud container image with binary as entrypoint #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was an entrypoint script as a helper to manage crc-cloud operations, this will require extra work to adapt to new providers, instead of using an entrypoint helper now the image will use crc-cloud binary as entrypoint. In case of new providers or parameters there is no need to add nothing specific on the image as parameters for crc-cloud will be passed as args for the image entrypoint
guy9050
reviewed
Feb 8, 2023
|
|
||
| ENV INTERNAL_OUTPUT /tmp/crc-cloud | ||
| COPY --from=builder /workspace/out/crc-cloud /workspace/pulumi/pulumi /usr/local/bin/ |
There was a problem hiding this comment.
While I understand the idea of this PR, I'm new to pulumi and I don't quite understand how/where this crc-cloud binary is built? is this happening here? because of the --from=builder?
There was a problem hiding this comment.
Hey @guy9050 sure this is a multistage buiild. As you can see from line 1 to line 14 there is a initial container (builder) with all the requirements to build the crc-cloud binary. And on that container is where crc-cloud binary is built
The second stage just picks assets from the builder, this allows to create a slim image without unnecessary assets for runtime (the crc-cloud image is only this second stage image)
guy9050
approved these changes
Feb 11, 2023
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was an entrypoint script as a helper to manage crc-cloud operations, this will require extra work to adapt to new providers, instead of using an entrypoint helper now the image will use crc-cloud binary as entrypoint.
In case of new providers or parameters there is no need to add nothing specific on the image as parameters for crc-cloud will be passed as args for the image entrypoint
This commit contains existing crc-cloud image:
quay.io/crcont/crc-cloud@sha256:bec3a9190e73c2053aaf8160f0e9059d0a510db0147cfb59a77f0d08142d4e41And also matches with the information provided by #35