chore(tests): check tab existence differently

Signed-off-by: Daniel Villanueva <davillan@redhat.com>
crc-org · Nov 7, 2024 · e0cce79 · e0cce79
1 parent ca7b419
commit e0cce79
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/tests/src/openshift-local-extension.spec.ts b/tests/src/openshift-local-extension.spec.ts
@@ -24,6 +24,7 @@ import { OpenShiftLocalExtensionPage } from './model/pages/openshift-local-exten
 let extensionInstalled = false;
 let extensionCard: ExtensionCardPage;
 let resourcesPage: ResourceConnectionCardPage;
+let preferencesPage: PreferencesPage;
 const imageName = 'ghcr.io/crc-org/crc-extension:latest';
 const extensionLabelCrc = 'redhat.openshift-local';
 const extensionLabelNameCrc = 'openshift-local';
@@ -42,6 +43,7 @@ test.beforeAll(async ({ runner, page, welcomePage }) => {
   await welcomePage.handleWelcomePage(true);
   extensionCard = new ExtensionCardPage(page, extensionLabelNameCrc, extensionLabelCrc);
   resourcesPage = new ResourceConnectionCardPage(page, 'crc');
+  preferencesPage = new PreferencesPage(page);
 });
 
 test.afterAll(async ({ runner }) => {
@@ -126,11 +128,12 @@ test.describe.serial('Red Hat OpenShift Local extension verification', () => {
       const settingsBar = await navigationBar.openSettings();
       await playExpect(resourcesPage.card).toHaveCount(0);
       //checking settings/preferences assets
-      const preferencesPage = await settingsBar.openTabPage(PreferencesPage);
+      //const preferencesPage = await settingsBar.openTabPage(PreferencesPage);
       const preferencesTab = await preferencesPage.getTab();
       await preferencesTab.click();
-      await playExpect(preferencesTab.getByLabel('Extension: Red Hat OpenShift Local')).not.toBeVisible(); //this step will fail
-      await playExpect(preferencesPage.getPage().getByRole('region', {name: 'Content'}).getByText('Extension: Red Hat OpenShift Local')).toBeVisible(); //this step will fail
+      //await playExpect(preferencesTab.getByLabel('Extension: Red Hat OpenShift Local')).not.toBeVisible(); //this step will fail
+      //await playExpect(preferencesPage.getPage().getByRole('region', {name: 'Content'}).getByText('Extension: Red Hat OpenShift Local')).toBeVisible(); //this step will fail
+     await playExpect(settingsBar.getSettingsNavBarTabLocator('Extension: Red Hat OpenShift Local')).not.toBeVisible(); //this step will fail
     });
 
     test('Extension can be re-enabled correctly', async ({ navigationBar }) => {
@@ -148,11 +151,12 @@ test.describe.serial('Red Hat OpenShift Local extension verification', () => {
       const settingsBar = await navigationBar.openSettings();
       await playExpect(resourcesPage.card).toBeVisible();
       //checking settings/preferences assets
-      const preferencesPage = await settingsBar.openTabPage(PreferencesPage);
+      //const preferencesPage = await settingsBar.openTabPage(PreferencesPage);
       const preferencesTab = await preferencesPage.getTab();
       await preferencesTab.click();
-      await playExpect(preferencesTab.getByLabel('Extension: Red Hat OpenShift Local')).toBeVisible();
-      await playExpect(preferencesPage.getPage().getByRole('region', {name: 'Content'}).getByText('Extension: Red Hat OpenShift Local')).toBeVisible();
+      //await playExpect(preferencesTab.getByLabel('Extension: Red Hat OpenShift Local')).toBeVisible();
+      //await playExpect(preferencesPage.getPage().getByRole('region', {name: 'Content'}).getByText('Extension: Red Hat OpenShift Local')).toBeVisible();
+      await playExpect(settingsBar.getSettingsNavBarTabLocator('Extension: Red Hat OpenShift Local')).toBeVisible();
     }); 
   });