Switch to UEFI for vfkit driver

[praveenkumar]

Question? Do we want to keep this "external kernel" code a while longer? If we switch crc/vfkit to use UEFI to boot the VM, this can be removed. Switching to UEFI might be as simple as https://github.com/cfergeau/crc/tree/uefi . Code was only compile-tested, I can test it if we want to make this move now.

Originally posted by @cfergeau in crc-org/snc#890 (comment)

[gbraad]

I do not see a need to support legacy boot mechanisms.

[praveenkumar]

We should do that in the beginning of next sprint because this is mostly on crc side and same bundle can be consumed for testing. Now if we really want to remove the initrd/vmliunz file from bundles then new bundles will not work with old version of crc but that is expected.

[gbraad]

old version of crc

how old. As I understand we have been delivering EFI-bootable images since ever. This got reviewed last year due to #3824

this is mostly on crc side and same bundle can be consumed for testing

Are you saying we might use this for testing? If so, this should be changed ASAP as this is not how it runs on the end-user's machine.

[cfergeau]

old version of crc

how old. As I understand we have been delivering EFI-bootable images since ever. This got reviewed last year due to #3824

versions of crc with uefi support will be able to start older bundles.

versions of crc without uefi support (ie everything we have released until now) won't be able to start newer bundles if we remove the external kernel/initramfs.

Praveen was talking about the latter, you answered about the former.

[gbraad]

versions of crc without uefi support

And my take was: do we need to support this? This sounds unreasonable, as there might be other issues with this.

I believe the EUFI support came with macOS v13, right? And if so, the same cut-off to support v12 would apply to this.

[praveenkumar]

And my take was: do we need to support this? This sounds unreasonable, as there might be other issues with this.

As I said we don't support the older crc release with newer bundle. Also it is not about v12 support even on v13 if someone using older version of crc and try to use newer bundle it is going to break once we remove the vmlinux/initrd file because that what till now we are using. We can have the PR now (on both crc/snc side) and snc side we put another PR to remove kernel related files.

[cfergeau]

I'd argue old crc / new bundle is supported unless https://github.com/crc-org/snc/blob/ecb02eb8606b4c9e7468885c06a1b8652714b9fc/crc-bundle-info.json.sample#L11 is changed.

[praveenkumar]

Yes we should change that once we remove kernel files as part of same PR.

[gbraad]

@vyasgun Thanks for looking into this.
Basically we obsolete the Legacy BIOS/boot option and make this UEFI-only, like we do with Hyper-V on Windows and Linux

[vyasgun]

maybe this should be assigned to @praveenkumar since the PR is already in place from his side
#4309

[praveenkumar]

I just used https://github.com/cfergeau/crc/tree/uefi one, work is done by @cfergeau

[cfergeau]

This is done, can be closed