[e2e] story_microshift ensures operational status for cluster #3857
Conversation
…deploy the sample service previously the test service was deployed right after the crc start finished successfully, now we add some checks before deploy the service to ensure the cluster is operational: crc status + dns pods running + ovn pods running
|
/retest |
| return nil | ||
| } | ||
|
|
||
| // This function will wait until the microshift cluster got operational |
There was a problem hiding this comment.
I have no comments, just maybe that the func doc comment usually starts with func name and describes output. But that's super minor.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsliacan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@adrianriobo: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@adrianriobo can we hold this a bit because I think some of those should be part of |
|
I would prefer to add this for the time being and then revert once you got the fix on What do you think you can just add your commit on your PR and the revert commit for this in there as well? |
Fix #3851
this commit may will be partially reverted on a following PR in case #3852 will be implemented