build(deps): bump github.com/golangci/golangci-lint from 1.53.3 to 1.55.2 in /tools

[dependabot]

Bumps github.com/golangci/golangci-lint from 1.53.3 to 1.55.2.

Release notes

Sourced from github.com/golangci/golangci-lint's releases.

v1.55.2

If you use and appreciate golangci-lint please think to support us (golangci-lint maintainers and linter authors). ❤️

Changelog

• 02b6600a build(deps): bump github.com/butuzov/ireturn from 0.2.1 to 0.2.2 (#4178)
• 5a0f059f build(deps): bump github.com/nunnatsa/ginkgolinter from 0.14.0 to 0.14.1 (#4171)
• e3c2265f build(deps): bump github.com/shirou/gopsutil/v3 from 3.23.9 to 3.23.10 (#4177)

v1.55.1

If you use and appreciate golangci-lint please think to support us (golangci-lint maintainers and linter authors). ❤️

Changelog

• 3d582093 build(deps): bump actions/setup-node from 3 to 4 (#4155)
• 5c19d1d3 build(deps): bump github.com/golangci/revgrep from v0.5.0 to v0.5.2 (#4154)
• 4068be1b build(deps): bump github.com/securego/gosec/v2 from 2.18.1 to 2.18.2 (#4153)
• 9b20d49d output: convert backslashes to forward slashes for GitHub Action annotations printer (#4149)

v1.55.0

If you use and appreciate golangci-lint please think to support us (golangci-lint maintainers and linter authors). ❤️

Changelog

• 4b188dbf Add "inamedparam": checks for interface method with unnamed params (#3793)
• 2d5d29f5 Add testifylint linter (#4103)
• 3c347996 Add a pre-commit hook to check all files (#4046)
• de1c3919 Add perfsprint linter (#3714)
• 8c178d38 add protogetter linter (#4069)
• c65ab4b7 build(deps): bump actions/checkout from 3 to 4 (#4065)
• b74ffbbe build(deps): bump docker/build-push-action from 4 to 5 (#4094)
• b974c308 build(deps): bump docker/setup-buildx-action from 2 to 3 (#4093)
• 47d7785c build(deps): bump docker/setup-qemu-action from 2 to 3 (#4095)
• cf93cf57 build(deps): bump github.com/4meepo/tagalign from 1.3.2 to 1.3.3 (#4143)
• 95edd30b build(deps): bump github.com/Abirdcfly/dupword from 0.0.12 to 0.0.13 (#4104)
• 5b402136 build(deps): bump github.com/breml/bidichk from 0.2.4 to 0.2.6 (#4044)
• c6eae6cb build(deps): bump github.com/breml/bidichk from 0.2.6 to 0.2.7 (#4101)
• f4b0ca78 build(deps): bump github.com/breml/errchkjson from 0.3.1 to 0.3.5 (#4042)
• c9956e8e build(deps): bump github.com/breml/errchkjson from 0.3.5 to 0.3.6 (#4102)
• 64e382b6 build(deps): bump github.com/butuzov/ireturn from 0.2.0 to 0.2.1 (#4142)
• cc022712 build(deps): bump github.com/daixiang0/gci from 0.11.0 to 0.11.1 (#4068)
• 615a52b9 build(deps): bump github.com/daixiang0/gci from 0.11.1 to 0.11.2 (#4090)
• 0605100c build(deps): bump github.com/ghostiam/protogetter from 0.2.2 to 0.2.3 (#4130)
• f18d712b build(deps): bump github.com/golangci/revgrep from 745bb2f7c2e6 to v0.5.0 (#4064)
• a69976a6 build(deps): bump github.com/jgautheron/goconst from 1.5.1 to 1.6.0 (#4055)
• 663d0022 build(deps): bump github.com/mgechev/revive from 1.3.2 to 1.3.3 (#4043)
• eeb20881 build(deps): bump github.com/mgechev/revive from 1.3.3 to 1.3.4 (#4087)
• 0e82ef5b build(deps): bump github.com/nunnatsa/ginkgolinter from 0.13.5 to 0.14.0 (#4117)
• 452410c9 build(deps): bump github.com/polyfloyd/go-errorlint from 1.4.4 to 1.4.5 (#4078)
• b673fb72 build(deps): bump github.com/ryanrolds/sqlclosecheck from 0.4.0 to 0.5.1 (#4071)
• 823f02dc build(deps): bump github.com/securego/gosec/v2 from 2.17.0 to 2.18.0 (#4120)

... (truncated)

Changelog

Sourced from github.com/golangci/golangci-lint's changelog.

v1.55.2

1. updated linters
   • ireturn: from 0.2.1 to 0.2.2
   • ginkgolinter: from 0.14.0 to 0.14.1

v1.55.1

1. updated linters
   • gosec: from 2.18.1 to 2.18.2
2. misc.
   • revgrep: from v0.5.0 to v0.5.2 (support git < 2.41.0)
   • output: convert backslashes to forward slashes for GitHub Action annotations printer

v1.55.0

1. new linters
   • gochecksumtype: https://github.com/alecthomas/go-check-sumtype
   • inamedparam: https://github.com/macabu/inamedparam
   • perfsprint: https://github.com/catenacyber/perfsprint
   • protogetter: https://github.com/ghostiam/protogetter
   • sloglint: https://github.com/go-simpler/sloglint
   • testifylint: https://github.com/Antonboom/testifylint
2. updated linters
   • bidichk: from 0.2.4 to 0.2.7
   • decorder: from 0.4.0 to 0.4.1
   • dupword: from 0.0.12 to 0.0.13
   • errchkjson: from 0.3.1 to 0.3.6
   • gci: from 0.11.0 to 0.11.2
   • ginkgolinter: from 0.13.5 to 0.14.0
   • go-errorlint: from 1.4.4 to 1.4.5
   • gocognit: from 1.0.7 to 1.1.0
   • goconst: from 1.5.1 to 1.6.0
   • godot: from 1.4.14 to 1.4.15
   • gofmt: update to HEAD
   • goimports: update to HEAD
   • gosec: from 2.17.0 to 2.18.1
   • gosmopolitan: from 1.2.1 to 1.2.2
   • govet: add appends analyzer
   • ireturn: from 0.2.0 to 0.2.1
   • protogetter: from 0.2.2 to 0.2.3
   • revgrep: from 745bb2f7c2e6 to v0.5.0
   • revive: from 1.3.2 to 1.3.4
   • sqlclosecheck: from 0.4.0 to 0.5.1
   • staticcheck: from 0.4.5 to 0.4.6
   • tagalign: from 1.3.2 to 1.3.3
   • unused: support passing in options
3. misc.
   • Add a pre-commit hook to check all files
4. Documentation

... (truncated)

Commits

• e3c2265 build(deps): bump github.com/shirou/gopsutil/v3 from 3.23.9 to 3.23.10 (#4177)
• 02b6600 build(deps): bump github.com/butuzov/ireturn from 0.2.1 to 0.2.2 (#4178)
• ab3c3cd build(deps): bump github.com/docker/docker from 23.0.3+incompatible to 24.0.7...
• 5a0f059 build(deps): bump github.com/nunnatsa/ginkgolinter from 0.14.0 to 0.14.1 (#4171)
• d201484 build(deps): bump google.golang.org/grpc from 1.55.0 to 1.56.3 in /tools (#4164)
• e9cbc4f docs: Update documentation and assets (#4163)
• 9b20d49 output: convert backslashes to forward slashes for GitHub Action annotations ...
• 3d58209 build(deps): bump actions/setup-node from 3 to 4 (#4155)
• 5c19d1d build(deps): bump github.com/golangci/revgrep from v0.5.0 to v0.5.2 (#4154)
• 4068be1 build(deps): bump github.com/securego/gosec/v2 from 2.18.1 to 2.18.2 (#4153)
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[openshift-ci]

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign praveenkumar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[praveenkumar]

/hold

Looks like we need manual intervention here.

[cfergeau]

GOARCH=amd64 GOOS=darwin "/Users/runner/work/crc/crc/tools/bin"/golangci-lint run
Error: pkg/crc/preflight/preflight.go:55:9: superfluous-else: if block ends with call to panic function, so drop this else and outdent its block (revive)
	} else {
		logging.Infof("%s", check.checkDescription)
	}
Error: test/integration/utilities_test.go:12:2: dot-imports: should not use dot imports (revive)
	. "github.com/onsi/gomega"
	^
Error: test/integration/podman_test.go:10:2: dot-imports: should not use dot imports (revive)
	. "github.com/onsi/ginkgo/v2"
	^
Error: test/integration/podman_test.go:11:2: dot-imports: should not use dot imports (revive)
	. "github.com/onsi/gomega"
	^
make: *** [cross-lint] Error 1
Error: Process completed with exit code 2.

[cfergeau]

/hold

Looks like we need manual intervention here.

I've done the manual intervention, though to fix some dot-import warnings from revive, we have 2 options, and I've done both in this PR, we need to choose which one to go with:

• disable the dot-import warnings and keep doing import . "github.com/../ginkgo" so that we can keep using It(" ...") instead of ginkgo.It(" ...") when writing our tests
• switch from It(" ...") to ginkgo.It(" ...")

I don't have a strong preference either way, dunno if someone has an opinion about this?

[praveenkumar]

/hold
Looks like we need manual intervention here.

I've done the manual intervention, though to fix some dot-import warnings from revive, we have 2 options, and I've done both in this PR, we need to choose which one to go with:

* disable the `dot-import` warnings and keep doing `import . "github.com/../ginkgo"` so that we can keep using `It(" ...")` instead of `ginkgo.It(" ...")` when writing our tests

* switch from  `It(" ...")` to `ginkgo.It(" ...")`

I don't have a strong preference either way, dunno if someone has an opinion about this?

I would say lets go with removing dot-import in our code base so may be drop f65ec54 ?

[cfergeau]

I added a 3rd way of dealing with the warnings, I think it's the option @adrianriobo favoured.

[cfergeau]

may be drop f65ec54 ?

Yes, once we decide which variant to go with, I'll drop the unneeded commits

[cfergeau]

I've rebased this and kept only one commit to fix the dotimport errors.
There are newer golangci-lint versions now, but they force an upgrade to golang 1.21, so I intentionnally stayed with the older/more compatible version.

[openshift-merge-robot]

rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.