Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: removed Podman preset mentions - fixes #4003 #4005

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Jan 31, 2024

Fixes: Issue #4003

Solution/Idea

The Podman preset is deprecated and will be removed in the next version. DOn't mention it in the documentation.

Proposed changes

Removed Podman preset mentions from the documentation.

Testing

The documentation does not mention the Podman preset.

Copy link

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign praveenkumar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

README.adoc Outdated Show resolved Hide resolved
@themr0c themr0c linked an issue Jan 31, 2024 that may be closed by this pull request
@praveenkumar
Copy link
Member

Can we squash those commit and put it as one? because second commit is just removing mistake from first one.

Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@themr0c
Copy link
Contributor Author

themr0c commented Feb 8, 2024

@praveenkumar squashed commits and rebased on main.

Copy link

openshift-ci bot commented Feb 8, 2024

@themr0c: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc 5f8980b link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@praveenkumar praveenkumar merged commit ddb8e8f into crc-org:main Feb 8, 2024
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove mentions about podman preset from docs
2 participants